Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme: restructure code #891

Closed
McShelby opened this issue Aug 25, 2024 · 0 comments
Closed

theme: restructure code #891

McShelby opened this issue Aug 25, 2024 · 0 comments
Assignees
Labels
breaking Introduces breaking changes with existing installations task Maintainence work
Milestone

Comments

@McShelby
Copy link
Owner

McShelby commented Aug 25, 2024

The theme uses a proprietary mechanism to allow for adjusting parts of the layout for different output partials. This has a lot of drawbacks:

  • users, familiar with Hugo need to learn a mechanism only used in the theme
  • the way it's implemented complicates code (to a degree even Joe Mooring on the official Hugo forum made an comment about it ;-) )
  • it restricts further development due to its complexity

The resulting capabilites of this mechanism can be implemented with all Hugo features, making it still complex but more common for advanced users and may profit from better caching (we'll see on that).

For that, the following changes will be implemented:

  • remove internal output-partial mechanism by reverting back to standard partial calls
  • simpify the archetype support by not clattering it in multiple files -> changing frontmatter archetype to type (which is a built-in Hugo frontmatter option)
  • leverage baseof templates
  • base it on Hugos .Render function
  • renaming/moving templates meant for internal usage
@McShelby McShelby added this to the 6.2.0 milestone Aug 26, 2024
@McShelby McShelby self-assigned this Aug 26, 2024
@McShelby McShelby added task Maintainence work breaking Introduces breaking changes with existing installations labels Aug 26, 2024
@McShelby McShelby modified the milestones: 6.2.0, 7.0.0 Aug 26, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
content.html is meant to be overloaded by the user and it should just work
so every logic needs to be put somewhere else
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
McShelby added a commit that referenced this issue Sep 20, 2024
to avoid to be interpreted as indented code in some scenarios
McShelby added a commit that referenced this issue Sep 24, 2024
this caused ill formatting for .article-subheading in print outputformat
McShelby added a commit that referenced this issue Sep 24, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
content.html is meant to be overloaded by the user and it should just work
so every logic needs to be put somewhere else
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
McShelby added a commit that referenced this issue Oct 11, 2024
to avoid to be interpreted as indented code in some scenarios
McShelby added a commit that referenced this issue Oct 11, 2024
this caused ill formatting for .article-subheading in print outputformat
McShelby added a commit that referenced this issue Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces breaking changes with existing installations task Maintainence work
Projects
None yet
Development

No branches or pull requests

1 participant