-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update mermaid to 10.3.0 #603
Conversation
Needs more work, sankey isn't working. |
Please add a sankey example taken from the Mermaid docs into the Themes Mermaid page. |
MermaidJS is deprecating the support for directives for all new stuff. |
Well. Mermaid becomes a mess in my opinion but my impression might come from a lack of communication. Anyways I will not add workarounds nor a half working Mermaid version to the release until mermaid-js/mermaid#4630 is closed and a clear alternative is announced. |
mermaid is deprecating directives for new diagram types: mermaid-js/mermaid#4630
aa98b51
to
853da37
Compare
The alternative seems to be the yaml style config: mermaid-js/mermaid#4630 (comment) I added a workaround which should not break compatibility with existing diagrams. When the original diagram has no directive, its adding the default theme as yaml config, if the diagram has a directive, it adds the theme, when its missing like before this PR. |
The sankey graph currently breaks in this PR if the theme variant is switched from Relearn Light to Relearn Dark. Also the generated empty JSON inside of YAML looks suspicious to me:
|
Thanks for the feedback, i will look into this next week. |
Sankey diagram isn't using yaml/directive currently
Both should be fixed now. And now i understand, what you mean with mermaidJS is a mess. |
Thanks for working on this. It still did not work, because the theme setting will always be written to the Could you confirm that it works for your test cases. |
Works for me, thanks. |
fixes: #601