Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: attempt to index global 'self' (a nil value) #109

Closed
mrchops1024 opened this issue Sep 10, 2024 · 8 comments · Fixed by #111
Closed

Bug: attempt to index global 'self' (a nil value) #109

mrchops1024 opened this issue Sep 10, 2024 · 8 comments · Fixed by #111
Labels
bug Something isn't working

Comments

@mrchops1024
Copy link

Version: 1.6.0

Error message:

Message: Interface/AddOns/RPGLootFeed/Features/ItemLoot.lua:48: attempt to index global 'self' (a nil value)

==== Addon Info RPGLootFeed v1.6.0-1-f1ef139 ====

Log traces related to ItemLoot

[16:59:53]{I}(WOW)[ITEM] :CHAT_MSG_LOOT You create: [Conjured Mana Bun]x20.
[16:59:35]{I}(WOW)[ITEM] :CHAT_MSG_LOOT You create: [Conjured Mana Bun]x20.

Please report this issue @ github: McTalian/RPGLootFeed

Time: Mon Sep 9 16:59:53 2024
Count: 1
Stack: Interface/AddOns/RPGLootFeed/Features/ItemLoot.lua:48: attempt to index global 'self' (a nil value)

==== Addon Info RPGLootFeed v1.6.0-1-f1ef139 ====

Log traces related to ItemLoot

[16:59:53]{I}(WOW)[ITEM] :CHAT_MSG_LOOT You create: [Conjured Mana Bun]x20.
[16:59:35]{I}(WOW)[ITEM] :CHAT_MSG_LOOT You create: [Conjured Mana Bun]x20.

Please report this issue @ github: McTalian/RPGLootFeed

@Mctalian Mctalian added the bug Something isn't working label Sep 10, 2024
@Mctalian
Copy link
Owner

Thank you! I'll get this fixed asap!

@mrchops1024
Copy link
Author

Just an update, it appears to be almost anything I loot throws this error.

@Mctalian
Copy link
Owner

Good to know, sounds like I just missed something simple, should be a quick fix

@Mctalian
Copy link
Owner

Ah looks like you've got quality filters on. I see what needs to change, I'll get a quick update once I get to my PC

@mrchops1024
Copy link
Author

You are correct, I should have added that. I was waiting for the loot history to be implemented before I re-enable all loot categories. Thanks for the quick response.

@Mctalian
Copy link
Owner

/rlf loot will show a window with loot messages. I found it super helpful for testing and debugging but Idk how useful it will be for players. Open for feedback on it!

Mctalian added a commit that referenced this issue Sep 10, 2024
* Fix #109: lua error for filtered out loot quality
@Mctalian Mctalian mentioned this issue Sep 10, 2024
@Mctalian
Copy link
Owner

@mrchops1024 v1.6.1 should be available on the big 3 addon sites soon 🤞🏼 - thank you for the report!

Let me know what you are looking for in a loot history window and I can make some adjustments to fit your needs.

@mrchops1024
Copy link
Author

@mrchops1024 v1.6.1 should be available on the big 3 addon sites soon 🤞🏼 - thank you for the report!

So far, so good. Appreciate the quick fix.

Let me know what you are looking for in a loot history window and I can make some adjustments to fit your needs.

I'm not sure if this thread is the right place, but something like an 'activated-when-hovered-over' window that you can scroll up/down through. I like that I can filter on item quality and have a dedicated place to see loot history, for when I'm not paying attention to my chat window.

When I installed the addon, the first thing I tried to do was see if I could 'un-hide' the loot area to see the history. It seemed like an intuitive feature to have, and would suffice for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants