Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Implement reverse file reading #17

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obsoleszenz
Copy link
Contributor

@obsoleszenz obsoleszenz commented Apr 17, 2022

Addresses #14

Todo

  • Implement reverse reading in decode_symphonia
  • Use it in core/caching logic
  • rebase on main once Actually fix ci #16 is merged

Be-ing and others added 2 commits June 10, 2022 19:52
Once the end of the file is reached, the EndOfFile error should be
returned indefinitely until a seek is done.
@obsoleszenz obsoleszenz force-pushed the feat_decode_reverse branch from 6fb5e32 to 519de76 Compare June 10, 2022 17:52
@Be-ing
Copy link
Collaborator

Be-ing commented Jun 17, 2022

Could you add a reverse button to the demo player?

@obsoleszenz
Copy link
Contributor Author

Could you add a reverse button to the demo player?

I guess yes but makes not too much sense without any functionality? ^^ I still didn't figure out the caching part :/

@Be-ing Be-ing marked this pull request as draft July 10, 2023 08:57
@abique
Copy link

abique commented Jan 21, 2024

From a naive perspective, I'd be interested in:

  • telling how much cache I want before my current position
  • telling how much cache I want after my current position
  • Peek buffer at pos and then seek, or have a direction argument to read()

That way I can play forward/backward, implement scratching etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants