-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to run without NetworkTables #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new API. The only change to make is switching the persistent and alias fields to use update
rather than append
(for both Java and C++). Since they don't change often there's no point filling up the log unnecessarily (normally it would rely on NT to do change checking).
Update wont exist until we are on 2025 versions of WPILib I believe Do we want to hold off on merging this till 2025 beta is released or merge this and change it later? |
This reverts commit 73dfb6b.
I believe we're building against the WPILib development builds, so |
We are building against WPILibs 2024 artifacts which are no longer development builds |
Right, yes. I think we should hold off merging this on the 2024 builds, but I also don't see any reason not to update URCL to the 2025 artifacts at this point. I can do that soon, or feel free to just add it to this PR if you prefer. |
This reverts commit 72a5ec6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating to 2025. Java looks good, I just noticed a couple of odd things on the C++ version
depends on #6
closes #5