forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SPARK-1111: URL Validation Throws Error for HDFS URL's
Fixes an error where HDFS URL's cause an exception. Should be merged into master and 0.9. Author: Patrick Wendell <pwendell@gmail.com> Closes apache#625 from pwendell/url-validation and squashes the following commits: d14bfe3 [Patrick Wendell] SPARK-1111: URL Validation Throws Error for HDFS URL's (cherry picked from commit 45b15e2) Signed-off-by: Aaron Davidson <aaron@databricks.com>
- Loading branch information
Showing
2 changed files
with
42 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
core/src/test/scala/org/apache/spark/deploy/ClientSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.deploy | ||
|
||
import org.scalatest.FunSuite | ||
import org.scalatest.matchers.ShouldMatchers | ||
|
||
class ClientSuite extends FunSuite with ShouldMatchers { | ||
test("correctly validates driver jar URL's") { | ||
ClientArguments.isValidJarUrl("http://someHost:8080/foo.jar") should be (true) | ||
ClientArguments.isValidJarUrl("file://some/path/to/a/jarFile.jar") should be (true) | ||
ClientArguments.isValidJarUrl("hdfs://someHost:1234/foo.jar") should be (true) | ||
|
||
ClientArguments.isValidJarUrl("hdfs://someHost:1234/foo") should be (false) | ||
ClientArguments.isValidJarUrl("/missing/a/protocol/jarfile.jar") should be (false) | ||
ClientArguments.isValidJarUrl("not-even-a-path.jar") should be (false) | ||
} | ||
|
||
} |