Move logic from __init_.py to schema submodules. Ref #3. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompollard
force-pushed
the
tp/init_to_module
branch
from
372d4d4
to
8b120aa
Compare
tompollard
force-pushed
the
tp/init_to_module
branch
from
8b120aa
to
9ac50a4
Compare
tompollard
changed the title
|
This all looks good! I like the deprecation warning to make this easier to merge |
EthanSteinberg
approved these changes
Jan 13, 2024
|
thanks ethan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most of the logic in this repository is in https://github.com/Medical-Event-Data-Standard/meds/blob/main/src/meds/__init__.py (see #3).
This pull request addresses #3 by:
__init__.pytoschema.py.__init__.py__init__.pyfor the old import syntax.Why make this change? The goal is to move the repository towards a more modular strucure, making it simpler to navigate and maintain and more flexible if we expand in future.
The old import syntax will continue to work, but it has been marked as deprecated:
from meds import patient_schema.from meds.schema import patient_schema.