Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-bool Label value options #18

Merged

Conversation

Miking98
Copy link
Collaborator

Needed to support benchmarks like EHRSHOT (certain labeling functions have categorical / integer label values)

Needed to support benchmarks like EHRSHOT
@EthanSteinberg EthanSteinberg self-requested a review March 26, 2024 20:44
Copy link
Collaborator

@EthanSteinberg EthanSteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is mostly good! Can you also add some examples of theses labels to the unit tests.

src/meds/schema.py Outdated Show resolved Hide resolved
src/meds/schema.py Outdated Show resolved Hide resolved
@Miking98
Copy link
Collaborator Author

Fixed! Would appreciate pulling these in so I can work with EHRSHOT.

@Miking98
Copy link
Collaborator Author

Miking98 commented Apr 3, 2024

Hey how can I pull this in? I don't seem to have write permissions

@EthanSteinberg
Copy link
Collaborator

@Miking98 Let me merge this in, then give you permission to merge in future PRs.

@EthanSteinberg EthanSteinberg merged commit b5a62c6 into Medical-Event-Data-Standard:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants