Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple github workflow. #6

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add simple github workflow. #6

merged 1 commit into from
Jan 9, 2024

Conversation

tompollard
Copy link
Contributor

This pull request adds a github workflow that will run pytest on pull requests to main.

Currently there are no tests, so nothing really happens. Tests are added in #5.

@EthanSteinberg
Copy link
Collaborator

This looks mostly good. My main comment is that we also want to add a github workflow to publish packages, but that should be done in another PR.

@tompollard
Copy link
Contributor Author

My main comment is that we also want to add a github workflow to publish packages, but that should be done in another PR.

Thanks Ethan, sounds good. Are you happy with the approach suggested below, where this workflow runs every time a change is pushed to a "release" branch?

https://docs.github.com/en/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions#publishing-a-package-using-an-action

@tompollard tompollard merged commit 2dfb498 into main Jan 9, 2024
1 check passed
@tompollard tompollard deleted the tp/github_workflow branch January 9, 2024 12:10
@EthanSteinberg
Copy link
Collaborator

Thanks Ethan, sounds good. Are you happy with the approach suggested below, where this workflow runs every time a change is pushed to a "release" branch?

That generally looks like the right approach, but I like the "on: release" workflow trigger better.

See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release or https://github.com/som-shahlab/femr/blob/main/.github/workflows/build.yaml#L4 for a full example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants