update phantomjs to 1.9.7 #131

monbro · 2014-01-27T15:06:18Z

No description provided.

monbro · 2014-01-27T15:26:13Z

As We are having errors wit the 1.9.6 version

[exec] Using the selenium server at http://localhost:4444/wd/hub
     [exec] 
     [exec] /var/lib/jenkins/workspace/x/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1542
     [exec]       throw error;
     [exec]             ^
     [exec] UnknownError: Error - Cannot find module 'cookiejar'
     [exec] Command duration or timeout: 509 milliseconds
     [exec] Build info: version: '2.37.0', revision: 'a7c61cb', time: '2013-10-18 17:14:00'
     ...

upgrading to 1.9.7 solved our problem

dpup · 2014-01-27T15:33:26Z

I know it's a small patch but would you mind signing the CLA: https://github.com/Obvious/open-source

Otherwise I can do this later today.

monbro · 2014-01-27T16:00:22Z

No worries, done Medium/opensource#41

update phantomjs to 1.9.7

dpup · 2014-01-27T16:12:24Z

Published to NPM.

XhmikosR · 2014-01-27T16:39:43Z

I'm getting an error when trying to install a module that has phantomjs as a dependency after the1.9.7 update.

> phantomjs@1.9.7-0 install C:\Users\xmr\Desktop\mpc-hc.org\node_modules\grunt-uncss\node_modules\uncss\node_modules\phantomjs
> node install.js

Downloading http://cdn.bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.7-windows.zip
Saving to C:\Users\xmr\AppData\Local\Temp\phantomjs\phantomjs-1.9.7-windows.zip
Receiving...
Error requesting archive
Phantom installation failed [Error: Error with http request: { 'content-type': '
application/xml',
  'transfer-encoding': 'chunked',
  connection: 'keep-alive',
  date: 'Mon, 27 Jan 2014 16:35:06 GMT',
  server: 'AmazonS3',
  'x-cache': 'Error from cloudfront',
  via: '1.1 02fd383853ef3b6dd024813a9b190dcb.cloudfront.net (CloudFront)',
  'x-amz-cf-id': 'halckiQ23OnG0RzPG3E-eeoAKLTlOR3Ea6eN1CLKjn5mWy-Z-Pj3gA==' }] Error: Error with http request: { 'content-type': 'application/xml',
  'transfer-encoding': 'chunked',
  connection: 'keep-alive',
  date: 'Mon, 27 Jan 2014 16:35:06 GMT',
  server: 'AmazonS3',
  'x-cache': 'Error from cloudfront',
  via: '1.1 02fd383853ef3b6dd024813a9b190dcb.cloudfront.net (CloudFront)',
  'x-amz-cf-id': 'halckiQ23OnG0RzPG3E-eeoAKLTlOR3Ea6eN1CLKjn5mWy-Z-Pj3gA==' }
    at ClientRequest.<anonymous> (C:\Users\xmr\Desktop\mpc-hc.org\node_modules\grunt-uncss\node_modules\uncss\node_modules\phantomjs\install.js:227:23)
    at ClientRequest.g (events.js:180:16)
    at ClientRequest.EventEmitter.emit (events.js:95:17)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (http.js:1688:21)
    at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:121:23
)
    at Socket.socketOnData [as ondata] (http.js:1583:20)
    at TCP.onread (net.js:525:27)
npm http 304 https://registry.npmjs.org/core-util-is
npm http 304 https://registry.npmjs.org/debuglog/0.0.2
npm http 304 https://registry.npmjs.org/string_decoder
npm ERR! phantomjs@1.9.7-0 install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the phantomjs@1.9.7-0 install script.
npm ERR! This is most likely a problem with the phantomjs package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls phantomjs
npm ERR! There is likely additional logging output above.

npm ERR! System Windows_NT 6.1.7601
npm ERR! command "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! cwd C:\Users\xmr\Desktop\mpc-hc.org
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.24
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     C:\Users\xmr\Desktop\mpc-hc.org\npm-debug.log
npm ERR! not ok code 0

ariya · 2014-01-27T17:23:30Z

The Windows binary is not ready yet. I really really recommend updating the installer only after any release is officially announced (check http://phantomjs.org/download.html), otherwise this kind of situation may happen.

XhmikosR · 2014-01-27T17:26:26Z

I didn't update anything. I simply checked out a package which has phantomjs as a dependency and this happens.

gonzofish · 2014-01-27T17:26:50Z

To follow on-to @XhmikosR 's comment, users on Windows cannot run npm install phantomjs because it's attempting to point to the 1.9.7 binary, which doesn't exist.

EDIT: I mean that the BitBucket file for Windows@1.9.7 doesn't exists.

gonzofish · 2014-01-27T17:30:49Z

@XhmikosR as @dpup told me, just set your package.json to 1.96 for now

XhmikosR · 2014-01-27T17:32:22Z

I can't do that @gonzofish it's not my package...

unscrum · 2014-01-27T17:34:02Z

when pulling the 0.9.7 version i'm getting an error, not sure if its from the package for from amazon. Currently i'm references karma-phantomjs-launcher which references "~.9.0" version of phantom js.

Phantom installation failed [Error: Error with http request: { 'content-type': 'application/xml',

'content-length': '231',

connection: 'keep-alive',

date: 'Mon, 27 Jan 2014 16:49:27 GMT',

server: 'AmazonS3',

age: '280',

'x-cache': 'Error from cloudfront',

via: '1.1 efac54ef164557bd62190f547573846a.cloudfront.net (CloudFront)',

'x-amz-cf-id': 'W6AnEXF60XIscgYe2qip5SIPZB__-FVt0rpb6StnG6NdmE2BlwbX6Q==' }] Error: Error with http request: { 'content-type': 'application/xml',

'content-length': '231',

connection: 'keep-alive',

date: 'Mon, 27 Jan 2014 16:49:27 GMT',

server: 'AmazonS3',

age: '280',

'x-cache': 'Error from cloudfront',

via: '1.1 efac54ef164557bd62190f547573846a.cloudfront.net (CloudFront)',

'x-amz-cf-id': 'W6AnEXF60XIscgYe2qip5SIPZB__-FVt0rpb6StnG6NdmE2BlwbX6Q==' }

at ClientRequest.<anonymous> (C:\....\node_modules\phantomjs\install.js:227:23)

at ClientRequest.g (events.js:180:16)

at ClientRequest.EventEmitter.emit (events.js:95:17)

at HTTPParser.parserOnIncomingClient [as onIncoming] (http.js:1688:21)

at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:121:23)

at Socket.socketOnData [as ondata] (http.js:1583:20)

at TCP.onread (net.js:525:27)

npm ERR! phantomjs@1.9.7-0 install: node install.js

npm ERR! Exit status 1

npm ERR!

npm ERR! Failed at the phantomjs@1.9.7-0 install script.

npm ERR! This is most likely a problem with the phantomjs package,

npm ERR! not with npm itself.

npm ERR! Tell the author that this fails on your system:

npm ERR! node install.js

npm ERR! You can get their info via:

npm ERR! npm owner ls phantomjs

npm ERR! There is likely additional logging output above.

npm ERR! System Windows_NT 6.1.7601

npm ERR! command "C:\Chocolatey\lib\nodist.0.3.12-beta\tools\nodist-master\bin\node.exe" "C:\Chocolatey\lib\nodist.0.3.12-beta\tools\nod

ist-master\bin\node_modules\npm\bin\npm-cli.js" "install" "phantomjs"

npm ERR! node -v v0.10.25

npm ERR! npm -v 1.3.25

npm ERR! code ELIFECYCLE

npm ERR!

npm ERR! not ok code 0

gonzofish · 2014-01-27T17:46:55Z

@unscrum if you're on Windows you are having the same issue as described by @XhmikosR and myself above.

XhmikosR · 2014-01-27T17:47:23Z

Now it seems to work fine.

gonzofish · 2014-01-27T17:56:38Z

Thanks guys for that quick turnaround!

dpup · 2014-01-27T18:11:14Z

I plan to rollback the release. Will need to be after lunch (PST).

-- Dan

On Mon, Jan 27, 2014 at 9:23 AM, Ariya Hidayat notifications@git.luolix.topwrote:

The Windows binary is not ready yet. I really really recommend updating
the installer only after any release is officially announced (check
http://phantomjs.org/download.html), otherwise this kind of situation may
happen.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/131#issuecomment-33398353
.

ariya · 2014-01-27T18:26:51Z

Windows binary of 1.9.7 has been uploaded to Bitbucket download.

XhmikosR · 2014-01-27T18:30:55Z

Thanks!

orneryd · 2014-01-27T18:48:53Z

from ariya/phantomjs#11933:

Thanks for your work on phantomjs. However, next time please ensure the file is available on cdn before updating your npm repo settings, our builds were broken for two hours because of this.

This happened with the latest release of 1.9.7, karma-phantomjs-launcher's dependency is "~1.9" which broke everything for a while.

Thanks.

ariya · 2014-01-27T18:50:49Z

@timothyswt Please read my previous comment (scroll up). I am not the one who is updating this npm.

I even haven't announced 1.9.7 to the public yet. Why am I getting a flak for this?

dpup · 2014-01-27T18:52:23Z

This was my fault for not verifying. I normally do, but was in a rush this
morning. I would also recommend fixing your package.json to a fixed
version, depending on wildcard versions is a recipe for being broken by
external changes.

-- Dan

On Mon, Jan 27, 2014 at 10:48 AM, Tim Sweet notifications@git.luolix.topwrote:

from ariya/phantomjs#11933 ariya/phantomjs#11933

Thanks for your work on phantomjs. However, next time please ensure the
file is available on cdn before updating your npm repo settings, our builds
were broken for two hours because of this.

This happened with the latest release of 1.9.7, karma-phantomjs-launcher's
dependency is "~1.9" which broke everything for a while.

Thanks.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/131#issuecomment-33407021
.

unscrum · 2014-01-27T19:24:28Z

Thanks for the quick turn around

monbro · 2014-01-27T20:47:31Z

@dpup sorry I also did not realize that it is for a reason not announced public…

On the other hand it does not work to set a specific phantomjs version for the wrapper yet.

{
    "dependencies": {
        "phantomjs": "1.9.6",
    }
}

Error:

npm ERR! Error: version not found: 1.9.6 : phantomjs/1.9.6
npm ERR!     at RegClient.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-registry-client/lib/request.js:275:14)
npm ERR!     at Request.self.callback (/usr/local/lib/node_modules/npm/node_modules/request/request.js:123:22)
npm ERR!     at Request.EventEmitter.emit (events.js:98:17)
npm ERR!     at Request.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/request/request.js:893:14)
npm ERR!     at Request.EventEmitter.emit (events.js:117:20)
npm ERR!     at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/request/request.js:844:12)
npm ERR!     at IncomingMessage.EventEmitter.emit (events.js:117:20)
npm ERR!     at _stream_readable.js:920:16
npm ERR!     at process._tickCallback (node.js:415:13)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/isaacs/npm/issues>

npm ERR! System Darwin 13.0.0
npm ERR! command "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! cwd /Users/x/git/x/x
npm ERR! node -v v0.10.24
npm ERR! npm -v 1.3.21

So it would be awesome to be able to specify a version as a parameter to the NodeJS phantomjs wrapper.
There is already a issue for that: #112

monbro · 2014-01-27T20:51:41Z

Ah I see, it is more me being a retard. https://github.com/Obvious/phantomjs#versioning
Maybe it is possible to point each 1.9.6 to 1.9.6-0 ?

dpup · 2014-01-27T20:59:49Z

If we make modifications to the installer we need to version after the
hyphen.

-- Dan

On Mon, Jan 27, 2014 at 12:51 PM, Michael Klein notifications@git.luolix.topwrote:

Ah I see, it is more me being a retard.
https://github.com/Obvious/phantomjs#versioning
Maybe it is possible to point each 1.9.6 to 1.9.6-0 ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/131#issuecomment-33421251
.

monbro · 2014-01-27T21:06:17Z

I am not into this, but it is not possible to point 1.9.6 then to the latest like 1.9.6-4

Michael Klein added 2 commits January 27, 2014 14:45

phantomjs update to 1.9.7

207ee92

updates phantomjs to 1.9.7

26a4df5

monbro mentioned this pull request Jan 27, 2014

Add support for phantomjs new version like 1.9.7 #130

Closed

dpup pushed a commit that referenced this pull request Jan 27, 2014

Merge pull request #131 from monbro/master

c9638e0

update phantomjs to 1.9.7

dpup merged commit c9638e0 into Medium:master Jan 27, 2014

ariya mentioned this pull request Jan 27, 2014

who updates npm without adding the file to the cdn? ariya/phantomjs#11933

Closed

unscrum mentioned this pull request Jan 27, 2014

PhantomJS release karma-runner/karma-phantomjs-launcher#25

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update phantomjs to 1.9.7 #131

update phantomjs to 1.9.7 #131

monbro commented Jan 27, 2014

monbro commented Jan 27, 2014

dpup commented Jan 27, 2014

monbro commented Jan 27, 2014

dpup commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

ariya commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

gonzofish commented Jan 27, 2014

gonzofish commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

unscrum commented Jan 27, 2014

gonzofish commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

gonzofish commented Jan 27, 2014

dpup commented Jan 27, 2014

ariya commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

orneryd commented Jan 27, 2014

ariya commented Jan 27, 2014

dpup commented Jan 27, 2014

unscrum commented Jan 27, 2014

monbro commented Jan 27, 2014

monbro commented Jan 27, 2014

dpup commented Jan 27, 2014

monbro commented Jan 27, 2014

update phantomjs to 1.9.7 #131

update phantomjs to 1.9.7 #131

Conversation

monbro commented Jan 27, 2014

monbro commented Jan 27, 2014

dpup commented Jan 27, 2014

monbro commented Jan 27, 2014

dpup commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

ariya commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

gonzofish commented Jan 27, 2014

gonzofish commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

unscrum commented Jan 27, 2014

gonzofish commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

gonzofish commented Jan 27, 2014

dpup commented Jan 27, 2014

ariya commented Jan 27, 2014

XhmikosR commented Jan 27, 2014

orneryd commented Jan 27, 2014

ariya commented Jan 27, 2014

dpup commented Jan 27, 2014

unscrum commented Jan 27, 2014

monbro commented Jan 27, 2014

monbro commented Jan 27, 2014

dpup commented Jan 27, 2014

monbro commented Jan 27, 2014