This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
fix issue with tryPhantomjsInLib on Elastic Beanstalk #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention the issue relating to this PR: |
| test.done() | ||
| }) | ||
| } | ||
|
|
||
| exports.testBogusVerifyChecksum = function (test) { | ||
| util.verifyChecksum(path.resolve(__dirname, './exit.js'), 'blargh') | ||
| .then(function (success) { | ||
| test.ok(!success, 'Expected checksum to fail') | ||
| .then(function (binaryLocation) { |
There was a problem hiding this comment.
Whoops, let me revert that. Thanks for catching it. Changed the wrong test!
|
thanks for diagnosing this! would you mind filling out a CLA real quick? https://github.com/Medium/opensource/blob/master/sign-cla.md |
|
Signed the CLA |
|
@nicks mind merging this and bumping the version when you get a chance? Thanks so much! |
|
sure, it may take me a little bit to get to it though |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.1.7,
tryPhantomjsInLibwouldn't overwritelocation.jsif phantomjs was foundIn v2.1.8,
tryPhantomjsInLibwould overwritelocation.jswith an absolute location if phantomjs was foundThis breaks Elastic Beanstalk because they put your app in
/tmp/deployment, runnpm installandnpm rebuild, then move your app to/var/app/current.The
npm rebuildwas causinglocation.jsto have an absolute path as the location, which was no longer valid once the app was moved to/var/app/currentinstead of/tmp/deployment.The change I made should preserve some of the code cleanup by conditionally overwriting
location.jsiffindValidPhantomJsBinaryreturns a valid path.Please bump the patch version after this is merged since it's a breaking change affecting all current Elastic Beanstalk deploys :)
Thanks for your work on this repo!