Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] harbour-meecast-eventview package not available at OpenRepos #68

Closed
Olf0 opened this issue Oct 13, 2024 · 6 comments
Closed

[Bug] harbour-meecast-eventview package not available at OpenRepos #68

Olf0 opened this issue Oct 13, 2024 · 6 comments

Comments

@Olf0
Copy link
Member

Olf0 commented Oct 13, 2024

@vasvlad, when performing my review WRT the separation of the event and eventview sub-packages, I discovered that the harbour-meecast-eventview package is not uploaded on the Meecast Event View page at OpenRepos in addition to the harbour-meecast-event package.

The split into two separate packages was explicitly performed to allow appropriate packages for SailfishOS ≥ 4.6.0 and SailfishOS < 4.6.0 to coexist in a single RPM repository, in order to make MeeCast(-Eventview) installable for users of all SailfishOS releases from a single repository (i.e. yours at OpenRepos) again.

Please tell me if I missed an aspect; if I did not, please upload the harbour-meecast-eventview package on the Meecast Event View page at OpenRepos (in addition to the harbour-meecast-event package) now and in the future.

@Olf0
Copy link
Member Author

Olf0 commented Nov 11, 2024

@vasvlad, as already stated: Please name a reason not to upload harbour-meecast-eventview package at OpenRepos or just upload it there.

This may be the only reason why people report MeeCast from OpenRepos not working properly in contrast to installing them from SailfishOS:Chum. Then PR #72 would be completely unnecessary! Unfortunately I have no way to test this, currently.

@vasvlad
Copy link
Member

vasvlad commented Nov 11, 2024

No reasons other than my lack of free time. :(
I've just created the new package page: https://openrepos.net/content/vasvlad/meecast-event-view-sailfishos-460
And change name in old package:
https://openrepos.net/content/vasvlad/meecast-event-view-sailfishos-460-0
Please check it.

@Olf0
Copy link
Member Author

Olf0 commented Nov 11, 2024

No reasons other than my lack of free time. :(

This is always fine, though sometimes unfortunate.

I've just created the new package page: https://openrepos.net/content/vasvlad/meecast-event-view-sailfishos-460 And change name in old package: https://openrepos.net/content/vasvlad/meecast-event-view-sailfishos-460-0 Please check it.

Oh, the idea was to make it easy for users by providing both packages in the same repository: RPM takes care about the "< 4.6.0" vs. "≥ 4.6.0" separation, this is exactly the reason why I named them differently and let them depend on sailfish-version mutually exclusive (i.e. either "< 4.6.0" or "≥ 4.6.0").

I suggest to please revert all these changes (altering the name of the page breaks many postings at FSO linking to it!) and to simply also upload the harbour-meecast-eventview package to a OpenRepos-page named https://openrepos.net/content/vasvlad/meecast-event-view (i.e. together with the harbour-meecast-event package to a page with the original name and URL).

Rationale: Both packages provide exactly the same functionality, thus for users there is not recognisable difference. And technically both packages share exactly the same source-code, only their RPM packaging (i.e. spec file) differs.

@vasvlad
Copy link
Member

vasvlad commented Nov 11, 2024

Hmm. I don't understand your idea. :( I have now implemented your request (reverted everything back). Please check it. I will need to upload both versions of the packages in the future to https://openrepos.net/content/vasvlad/meecast-event-view?

@Olf0
Copy link
Member Author

Olf0 commented Nov 11, 2024

Hmm. I don't understand your idea. :(

Sorry, then likely my explanation was not sufficient. I know discussing by typing messages can be tedious, but IMO we should take the time to achieve mutual understanding (e.g. we are working on the topic "make MeeCast compatible to SailfishOS ≥ 4.6.0" for months, so a couple of days do not make any significant difference). I really do not feel I am in the position to command you (and you simply execute; actually IMO nobody is in the position to command anybody, practically that solely ceases to be the case when in the military, facing the police etc.), even if this is about the specifics of RPM packaging (or CI workflow configuration etc.).

I have now implemented your request (reverted everything back). Please check it.

Thank you very much! You may denote on this page to notify the few users who manually download RPM packages from OpenRepos to explain the difference between the two packages. So my suggestion for the description field of this page at OpenRepos (i.e. replacing the text "Event's view for MeeCast") is to use the three lines below (the second of them being a blank line).
Side note: If you copy and paste at the GUI from one browser tab (this GitHub-issue) to another tab (with this OpenRepos page in edit-mode), the formatting is also copied so you do not have to recreate it.

The MeeCast eventview widget displays weather information at the top of SailfishOS' eventsview.

Note that the harbour-meecast-eventview packages are for SailfishOS ≥ 4.6.0 and the harbour-meecast-event packages for SailfishOS < 4.6.0.

I will need to upload both versions of the packages in the future to https://openrepos.net/content/vasvlad/meecast-event-view?

Yes. They all end up in the same RPM repository anyway (hence the different names were also technically necessary), because OpenRepos creates a single RPM repository for each registered user there. The package-specific web-pages at OpenRepos are only for describing (and discussing in the comments) different packages separately: This is why I strongly suggested to use only a single page for these two packages, because they provide the same functionality (and features, bugs, behaviour etc.), solely the SailfishOS-releases they target are different.

So please also upload the three packages harbour-meecast-event-1.11.7-1.{aarch64|armv7hl|i486}.rpm there. Then the long story of "making MeeCast compatible to SailfishOS ≥ 4.6.0" is concluded (I hope).

@Olf0 Olf0 closed this as completed Nov 11, 2024
@vasvlad
Copy link
Member

vasvlad commented Nov 12, 2024

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants