Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpm/meecast.spec] Overhaul spec file, 2nd round #57

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

Olf0
Copy link
Member

@Olf0 Olf0 commented Jul 4, 2024

Basically no altered functionality, but quite some changes in the spec file and another change in store:

  1. Enhance the metadata for SailfishOS:Chum of MeeCast proper and added SailfishOS:Chum-metadata for all sub-packages.

  2. Alter all version strings to adhere to Semantic Versioning ("SemVer"): three fields of digits (and an additional release string, as always), i.e. a.b.c-x.

  3. Re-order the sub-packages, to let the event sub-package become the last one specified, in order to reduce confusion when reading the spec file, because of …

  4. Split the Eventsview sub-package into two:

    • A sub-package eventview (a new name) for SailfishOS ≥ 4.6.0
    • A sub-package event (the original name) for SailfishOS < 4.6.0

    This allows to compile both sub-packages in one go and (more importantly) allows them to reside in the same repository (e.g. https://sailfish.openrepos.net/vasvlad/personal/main).

Olf0 added 2 commits July 5, 2024 00:00
No altered functionality!
… due to editorial changes all over the spec file.
@Olf0 Olf0 marked this pull request as ready for review September 8, 2024 19:42
@Olf0 Olf0 marked this pull request as draft September 8, 2024 21:38
@Olf0 Olf0 marked this pull request as ready for review September 8, 2024 21:39
@Olf0 Olf0 marked this pull request as draft September 8, 2024 21:39
@Olf0
Copy link
Member Author

Olf0 commented Sep 8, 2024

@vasvlad, this PR is ready for review.

You can merge this PR if you think it is O.K., but there is another change I believe to be inevitable:
Please also take a look at PR Olf0#2 and tell me if you are fine with it. I am not happy about working around the flaws of the SailfishOS-OBS, but because the SailfishOS:Chum repository relies on it, I see no other way. If you have other ideas how to handle that, please let me know.

Thanks & cheers!

@Olf0 Olf0 changed the title [rpm/meecast.spec] Beautify [rpm/meecast.spec] Overhaul spec file 2nd round Sep 8, 2024
@Olf0 Olf0 changed the title [rpm/meecast.spec] Overhaul spec file 2nd round [rpm/meecast.spec] Overhaul spec file, 2nd round Sep 8, 2024
@Olf0 Olf0 marked this pull request as ready for review September 8, 2024 22:57
@vasvlad vasvlad merged commit 77711c7 into Meecast:sailfishos Sep 9, 2024
@Olf0 Olf0 mentioned this pull request Sep 9, 2024
@Olf0 Olf0 deleted the patch-2 branch October 11, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants