Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash/tauri integration #76

Closed
wants to merge 8 commits into from
Closed

Bash/tauri integration #76

wants to merge 8 commits into from

Conversation

Bash-09
Copy link
Member

@Bash-09 Bash-09 commented Nov 5, 2023

Adds tauri integration to run the client as a desktop app (by adding --desktop when running the executable).

@Bash-09
Copy link
Member Author

Bash-09 commented Nov 7, 2023

On my machine there is a weird behaviour where the window creeps down a tiny bit each time it's opened and closed, but I think it has to do with the title bar on my Window manage as I've seen similar behaviour with other apps on my desktop before. If anybody could test on Windows that it stays in the same place each time it's closed and opened I would greatly appreciate that.

@Bash-09 Bash-09 force-pushed the Bash/tauri-integration branch 8 times, most recently from 43978ea to 59f8023 Compare November 7, 2023 01:38
@Bash-09 Bash-09 marked this pull request as ready for review November 7, 2023 01:48
@Bash-09 Bash-09 changed the title Draft: Bash/tauri integration Bash/tauri integration Nov 7, 2023
@Bash-09
Copy link
Member Author

Bash-09 commented Dec 2, 2023

For some reason the buttons to open steam profiles don't work from inside Tauri.

I added the shell-open feature and the following to the config, but that didn't seem to fix it. I'm not sure what I would have to enable for that to work.

  "tauri": {
    "allowlist": {
      "all": false
      "shell": {
        "open": true
      }
    },
 }

@Bash-09
Copy link
Member Author

Bash-09 commented Dec 3, 2023

For some reason the buttons to open steam profiles don't work from inside Tauri.
...

It seems that opening stuff from tauri requires it's own API instead of using the regular open functions like you would in a browser.

It could probably be worked around by having support in the UI to check if it's running in tauri and use the alternative API (see this github issue, but it's not ideal.

Besides having to add special cases to the UI to support it, I feel the many additional dependencies and the very negative impact on compile times by using tauri mean it's not worth merging it in in this state. I will leave this branch here though in case anybody else wants to have a look or finds a reasonable fix/alternative/compromise.

@Bash-09 Bash-09 closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant