Mixed tech intro date check #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases (usually involving mixed tech) tech will show available before it should because the check whether it was introduced does not account for the possibility that the intro date for the opposite tech base is sometimes -1 (DATE_NONE), which is always less than the current date.
sixlettervariables
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (usually involving mixed tech) tech will show available before it should because the check whether it was introduced does not account for the possibility that the intro date for the opposite tech base is sometimes -1 (DATE_NONE), which is always less than the current date.
This also can occur during the early Clan era when IS equipment is tweaked to be treated as Clan equipment, which is where I ran across it while working on MegaMek/megameklab#203