Protomech armor validation #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All protomech armor has a Clan tech base. Since standard uses the MiscType corresponding to T_STANDARD, and it has an tech level of Intro, it can't make the Clan/IS distinction and when the armor is set to standard in MML it is treated as IS and fails to match. The tech base match was kept when the code was copied from other unit types and modified, but is not necessary for protomechs.
neoancient
requested review from
sixlettervariables,
AaronGullickson and
NickAragua
sixlettervariables
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MegaMek/megameklab#344
Remove tech base check from protmech armor enum lookup.
All protomech armor has a Clan tech base. Since standard uses the MiscType
corresponding to T_STANDARD, and it has an tech level of Intro, it can't make
the Clan/IS distinction and when the armor is set to standard in MML it is
treated as IS and fails to match. The tech base match was kept when the code
was copied from other unit types and modified, but is not necessary for
protomechs.