Check equipment compatibility with motive type when validating vehicles #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
reviewed
Feb 18, 2020
| if (((WeaponType) eq).getAmmoType() == AmmoType.T_BPOD) { | ||
| return !isNaval; | ||
| } | ||
| if (((WeaponType) eq).getAmmoType() == AmmoType.T_NAIL_RIVET_GUN) { |
There was a problem hiding this comment.
What? VTOLs can't mount rivet guns? That's BS, I demand a refund! ::monocle::
There was a problem hiding this comment.
I think it's a total crock that submarines can't have combines. Hello? Kelp forests?
NickAragua
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the fix for MegaMek/megameklab#440. The bug report only mentions combat vehicle flotation hull, but I have included the amphibious and dune buggy CV mods, as well as industrial equipment and a few other equipment types I noticed. The logic is in a public static method in TestTank where it can be used by TestSupportVehicle, as well as MML in equipment filtering.