Armor rework, part 1a #5101
Merged
Armor rework, part 1a #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first half of the first step of reworking armor
EquipmentTypes to consolidate the armor statistics into one place and streamline their handling. The goal of the first part is to eliminate the static methods in EquipmentType and the construction data in Entity and TestEntity. This PR does so for armor names and weights/points per ton. I left it off here to keep the change from getting even bigger, but the second half of this step involves costs, removal of the remaining static methods from EquipmentType (many of which now simply pass the work on to ArmorType), and addition of support vehicle armors.