fix (partly) BA equipment text overlap #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes BA RS equipment overlap ... most of the time.
This PR reduces the minimum line distance and font size a bit, turns around scaling to reduce line spacing before font size and removes a line width adjustment for the location column that shouldn't be done on BA.
Edit: forgot to add what the actual change is: the scaleText() method had a logic error that would not ever let it reduce line spacing.
instead of
Unfortunately for some equipment the calculated line count is not quite right, causing overlap, and, so far, I was unable to see why. Maybe because the line counter will only count 2 lines at most while the actual equipment may even use 3 lines.
As this affects other unit types as well, I printed an Ares Hera and it still works