Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row shading for procedurally generated reference tables #1560

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

Previously row shading only existed for tables baked into the svgs of record sheet tables.

This pr adds row shading for all the reference tables which are proceduraly generated.

Care was taken to ensure the more unusually laid-out tables are shaded properly, but it's possible I missed something and will likely ask the QA testers to generate record sheets for all sorts of units and make sure they look ok with shading.

Shaded rows look like this:
image

The example is for vehicles, but all unit types are supported.

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.52%. Comparing base (bbb608c) to head (62cbfe4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1560      +/-   ##
===========================================
- Coverage      0.52%   0.52%   -0.01%     
  Complexity       49      49              
===========================================
  Files           265     265              
  Lines         30405   30424      +19     
  Branches       5174    5179       +5     
===========================================
  Hits            160     160              
- Misses        30204   30223      +19     
  Partials         41      41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IllianiCBT IllianiCBT merged commit f435ce2 into MegaMek:master Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants