-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental option for drawing armor pips in groups of 5 #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
===========================================
+ Coverage 2.15% 2.16% +0.01%
- Complexity 205 208 +3
===========================================
Files 266 266
Lines 30638 30731 +93
Branches 5236 5255 +19
===========================================
+ Hits 660 666 +6
- Misses 29825 29909 +84
- Partials 153 156 +3 ☔ View full report in Codecov by Sentry. |
HammerGS
added
Record Sheets
Record Sheets and PDF/Printing issue
For New Dev Cycle
This PR should be merged at the beginning of a dev cycle
labels
Aug 24, 2024
Thanks to TimberwolfD1 for providing SVG work to better support this armor layout scheme. |
pavelbraginskiy
force-pushed
the
grouped-armor-pips
branch
from
September 5, 2024 12:45
7fa3a50
to
e8b10e9
Compare
pavelbraginskiy
force-pushed
the
grouped-armor-pips
branch
2 times, most recently
from
September 15, 2024 20:10
6dd50f8
to
faab623
Compare
pavelbraginskiy
removed
the
For New Dev Cycle
This PR should be merged at the beginning of a dev cycle
label
Sep 21, 2024
Currently only implemented by the single-turret tank sheet. More record sheets supported soon.
pavelbraginskiy
force-pushed
the
grouped-armor-pips
branch
from
September 21, 2024 20:37
92c2e4b
to
7119d96
Compare
Merged
rjhancock
approved these changes
Sep 28, 2024
Just did a sanity check on code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people prefer the armor pip layout used by programs like Flechs, which renders armor pips in clusters of 5.
This pull request adds an option to attempt to render the armor pips in a similar fashion.
Even with the option enabled, not all unit types are supported, units where the alternate pip-placement method is known to not work well will always use the old drawing method.
Sometimes adding pips in groups of 5 fails, in which case the code simply falls back to the old method.
The option to enable this method is clearly marked as Experimental so people don't think this feature is guaranteed to produce good results. A future version of MML will remove the Experimental marker and have better support for more units.
I've playtested these sheets on the tabletop with players at my local LGS where they've been generally very well-received.
The following sheets have dedicated support, with custom pip layout hints:
The following sheets might be supported in the future, but are extremely rare and work ok without dedicated support:
The following units aren't supported, and armor pips will not be attempted to be drawn using the new method. These units mostly just have a completely different conception of how armor pips work for them, but for ProtoMeks specifically, it's because applying this method to their armor diagram causes the code to fail spectacularly in a way I haven't been able to really fix.
And now, some example record sheets: