Make IS and Clan structure available to mixed tech units. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #203: Inner Sphere Endo Steel is unavailable to early clan mechs.
sixlettervariables
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really clear what a Clan or IS tech base means in a mixed tech unit. There are entries in TROs that specify IS/mixed or Clan/mixed, but the mixed tech rules (TacOps, p. 377) don't really make it clear whether that means anything, or whether they amount to the same thing. For the sake of simplifying the code and the available options, MML uses the IS/Clan tech base to filter the available structure types, but this causes problems when it comes to early Clan units by making IS endo steel unavailable when they should be able to use it. (For that matter, the Clans should be able to construct a mixed tech unit with IS endo steel at any point in their history.)
Given the choice between a hack to deal specifically with IS Endo-Steel and a more general solution that basically ignores the distinction between IS mixed and Clan mixed*, I went with the latter.
*There is actually a distinction between IS mixed and Clan mixed, which is the availability and tech level of mixed tech units based on whether they are built by a Clan faction or an IS faction. But no difference for the unit construction.
Fixes #203: Inner Sphere Endo Steel is unavailable to early clan mechs.