-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record sheet font option #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add config option for user set the font for record sheets. If not set, look for Eurostile and if that isn't present use system default.
Added textLength attributes for static text.
Added textLength attributes for static text.
Added textLength attributes for static text.
Added textLength attributes for static text.
Added textLength attributes for static text.
Remove embedded fonts, increase spacing on weapons and inventory header.
Some options are now supported on non-mech sheets.
Commented out code that outputs generated svg document.
NickAragua
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this change is to remove proprietary font files that should not have been added in the first place. Instead the user is given the option of selecting an installed system font to use when printing record sheets. If the user has the font used for the official sheets installed, that one will be selected by default. Otherwise it will select the default system font initially. Most of the work involved removing fixed character spacing and making sure text would fit in available spaces as much as possible. Note that other than the newer sheets that are created by modifying the SVG document ('Mechs and advanced aerospace), most of the fixed text is treated as images and not modified by font selection.