-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vehicle construction #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently populated with combat vehicle views.
Checks for compatibility with installed mods. Requires prop mod for fixed wing with electric engine. Disallows external power pickup mod with maglev engine.
Added filtering of equipment.
Renamed to UnallocatedView to make the purpose clearer, made more generic and moved from vehicle package to general view package.
Moved armor methods into a separate interface.
On further reading of the rules, only small should allocate by point. Medium and large allocate by half ton as other units.
Fixed wing with electric engine -> Prop Rail with external engine -> external power pickup.
Units that allocate by point (e.g. small support vehicles) show "armor factor" and unit that allocate by weight show "armor tonnage"
Switch pod-mounted equipment to fixed when omni chassis mod is removed.
There are too many canon units that don't follow the dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to construct or modify support vehicles: all vehicle types currently supported by MegaMek with the addition of rail. Requires support_vee branch of MegaMek.
This is ready for testing and early review, but I want to hold it back until I write the validation code, which may reveal some things that need to change.