Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate variable equipment stats #499

Merged
merged 6 commits into from
Feb 25, 2020
Merged

Indicate variable equipment stats #499

merged 6 commits into from
Feb 25, 2020

Conversation

neoancient
Copy link
Member

Depends on MegaMek/megamek#1715

  1. Makes a distinction between equipment that has a weight/cost/BV/critical slots requirement of zero and equipment that is variable.
  2. BA, ProtoMechs, and small support vehicles show equipment weight by kg for everything rather than just what is < 0.1 tons. Anything >= 5 tons is filtered out for small support vehicles.
  3. Equipment shown as kg is shown as a whole number, with the exception of BA ammo, has official weights of partial kg.
  4. Fixed a bug introduced in my last equipment tab fix that had ammo, weapons, and structural components showing on the BA equipment tab in the "other" category.

Fixes #487

Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@neoancient neoancient merged commit 30a2e4f into master Feb 25, 2020
@neoancient neoancient deleted the variable_equipment branch February 25, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weights displayed inconsistently for combat vehicles (not particularly important)
3 participants