-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdf export #632
Merged
Merged
Pdf export #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle
# Conflicts: # build.gradle # src/megameklab/com/util/UnitPrintManager.java
Build scan available at https://gradle.com/s/yfa73f6763ope |
sixlettervariables
approved these changes
May 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works nicer than the Windows 10 PDF creation.
Build scan available at https://gradle.com/s/wmhakos5slyna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to export directly to PDF rather than depending on an external PDF printer driver. This results in a significant reduction in file size and memory usage, as the individual pages are cached in a temporary file when printing a multi-page document. The Apache FOP library provides the transcoder that converts the SVG document to PDF, and the Apache PDFBox library provides the PDF manipulation capability needed to assemble the individual documents to one multi-page document.
Adds an "export to PDF" item to the file menu, with submenu options that parallel the print menu.
The GitHub diff for UnitPrintManager makes the logic hard to follow. Basically what happens is the logic for instantiating the various record sheet classes is extracted from printAllUnits to its own method and shared with exportUnits. Most of the other print options are given an additional boolean parameter that determines whether to create a print job or export to PDF.
Fixes #342