Inventory overlap #649
Merged
Inventory overlap #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
requested review from
NickAragua,
AaronGullickson,
sixlettervariables,
SJuliez and
Windchild292
|
Build scan available at https://gradle.com/s/bxx2tbhl3zhkg |
Windchild292
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a text overlap issue in the inventory section of a record sheet. When the name or damage entry is too long to fit in the space it is split over multiple lines. There is a logic error that only moves the starting y coordinate of the next row of the text the necessary extra amount if the multi-line row is the last one in the entry.
Example:
In additional to correcting the logic error, I reduced the need for multiline text by limiting the (IS) and (Clan) indicators used on mixed tech units to equipment that has both IS and Clan variants. So in this example the AMS shows as (IS), but there is no need to specify the improved gauss rifle, which has no Clan version, or the prototype ER small lasers or improved LRM, which have no IS version.
