Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print pilot names #8

Merged
merged 4 commits into from
Jul 31, 2016
Merged

Print pilot names #8

merged 4 commits into from
Jul 31, 2016

Conversation

vizax
Copy link
Contributor

@vizax vizax commented Mar 23, 2016

Updated Coords for Pilot Name/Skills on:

  • Mech
  • Quad
  • Tripod

@vizax
Copy link
Contributor Author

vizax commented Mar 23, 2016

edit: Tripod has a gunner spot, put in the proper coords, but need to check on how it pulls the gunner

I checked the rest too.
PrintAero.java and PrintSmallCraftSpheroid.java had commented out the pilot fetching code. In my local files I have the code cleaned up and theoretically ready to go, but since I wasn't 100% positive, I didn't want to add them to this PR. Other things were missing too, like the import megamek.common.crew call. I'd like to work on these more, but I wanted to get some good data submitted while I take some time for the rest of it.

comments/suggestions/thoughts welcome. :-)

@arlith
Copy link
Contributor

arlith commented Mar 24, 2016

Multi-crew cockpits for 'mechs is still a pending feature for MM, so I don't know that you'll be able to get printing information for the gunner. The rest of it looks good and straightforward.

@arlith
Copy link
Contributor

arlith commented Mar 24, 2016

One other thing is, there's a docs/history.txt. When you make a bug fix or add a feature, it's good to add a line to that file. For instance, for this one you could add "+ PR #8: Adjust position of printed pilot names for Meks". This file gets used as the change log when releases are made, so try to word things so they would make sense to users.

@vizax
Copy link
Contributor Author

vizax commented Mar 24, 2016

Thanks for the info. I'll be sure to update the history file for this and the Indy TSM update I did too.

I did have problems last night with the Aero testing. I'm putting in static strings for reference and then just running MML through eclipse, and all the rest has worked fine, except Aero. When I print to (either to PDF or an actual printer) it hangs on the actual print. Example: I see the PDF conversion window open, and the progress bar may or may not start, but then it just sits. I've let it sit for up to 15 minutes. Thoughts on this? better/different way?

@arlith
Copy link
Contributor

arlith commented Mar 24, 2016

Have you tried checking the logfile to see if there were any errors in the log? It's possible there's a bug with Aero printing.

@vizax
Copy link
Contributor Author

vizax commented Mar 24, 2016

Silly me. However, there's nothing in the log. When I step through the code, it hangs on the below (see screenshot).
debug clip

I wasn't thinking straight last night, so I tested the actual release for MML, and cannot print an Aero sheet from it either. I'm going to table this for now, and raise the non-printing as a separate issue.

last commit is added code for when the print issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants