Added Campaign Option to Automate Retention Bonus Payments Based on a Threshold #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for bonus payout in the RetirementTableModel was updated to consider whether the turnover target number meets a given threshold. A new field for setting this threshold was added in the CampaignOptions class and its related GUI components.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4391 +/- ##
=========================================
Coverage 10.26% 10.27%
- Complexity 5809 5811 +2
=========================================
Files 925 925
Lines 125992 126022 +30
Branches 18618 18623 +5
=========================================
+ Hits 12939 12944 +5
- Misses 111777 111803 +26
+ Partials 1276 1275 -1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 13, 2024
The existing description for the retention bonuses option in the campaign options dialog was modified. "Pay Bonuses by Default" was replaced with "Automate Retention Bonuses" for clearer understanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a campaign option that if enabled automatically sets all turnover retention bonus payouts to
trueby default. This lacked nuance and usability, so I added a threshold option.Now bonus payouts will only default to
trueif the relevant campaign option is enabled and if the individual's turnover target number meets or exceeds a threshold set in campaign options.