Added Better Handling for Negative Skill Levels #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserted bounds checks using `max` to prevent negative values in experience calculations. Understandably, the rules in CamOps do not account for characters with -14 skill target numbers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5244 +/- ##
=========================================
Coverage 10.50% 10.50%
- Complexity 6044 6046 +2
=========================================
Files 957 957
Lines 134716 134725 +9
Branches 19572 19577 +5
=========================================
+ Hits 14149 14153 +4
- Misses 119216 119219 +3
- Partials 1351 1353 +2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserted bounds checks using
maxto prevent negative values in experience calculations. Understandably, the rules in CamOps do not account for characters with -14 skill target numbers.Closes #5238