-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations #83
Optimizations #83
Conversation
Make the change on line 731 like I mentioned in the comment, and this should be good to merge, assuming the CI build succeeds. |
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 87.19% 87.02% -0.17%
==========================================
Files 7 7
Lines 1616 1619 +3
Branches 314 295 -19
==========================================
Hits 1409 1409
- Misses 151 154 +3
Partials 56 56 |
I've changed |
seriously/SeriouslyCommands.py
Outdated
@@ -728,7 +728,7 @@ def dupe_each_n_fn(srs): | |||
tmp = [] | |||
while srs.stack: | |||
b = srs.pop() | |||
tmp = [b]*a + tmp | |||
tmp = [copy.deepcopy(b) for _ in range(a)] + tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't necessary - copy
in the global scope is a wrapper around copy.copy
(well, now, copy.deepcopy
) that properly handles generators. It should be tmp = [copy(b) for _ in range(a)] + tmp
.
I just noticed that you have an |
Actually, I shouldn't. |
No, |
No description provided.