-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/GitHubAction Templates for generated projects #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a really cool feature - however:
- I am super hesitant in adding a third step just for work flows. It seems almost out of scope for what I had initially wanted blueprint to be.
- This feature gave me an idea, maybe we can release a blueprint lite and blueprint full version that can include multiple steps into the process?
- There are merge conflicts, but I am not sure if i necessarily want this feature inside of blueprint right now. Sorry.
instead of adding a whole new step why don't we keep it flag only if user wants workflows they just use a flag |
I'm glad that the feature interests you, and we can implement it if you decide to do so. However, I find adding it without user consent to be tricky. When users open a new project that has just been created, the large number of files can be confusing. Lite and full versions or @20pa5a1210's idea(I like it); if needed, we can find a solution. |
I was actually think about this recently and there was an idea: |
I like the idea. I saw bsquidwrd propose this on Discord. What should I do with this PR? I can resolve the conflict and keep it up to date. However, I'm not sure that I can implement this feature alone. Some help would be nice, or I need more time to understand the logic behind it. |
There was a nasty conflict when merging my PR#108 into the staging branch. To resolve this, I created a fresh 'staging-2' branch from the current 'main' |
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Feature
I added a step for users to choose workflow templates for Go code tests when there is a push or pull request (PR) and 'goreliser' template used in this repository. I like having this feature in my projects. If you find it useful, I'm glad that I can contribute to this fire repo
Description of Changes:
Checklist