Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/GitHubAction Templates for generated projects #108

Merged
merged 18 commits into from
Nov 29, 2023

Conversation

Ujstor
Copy link
Collaborator

@Ujstor Ujstor commented Nov 15, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Feature

I added a step for users to choose workflow templates for Go code tests when there is a push or pull request (PR) and 'goreliser' template used in this repository. I like having this feature in my projects. If you find it useful, I'm glad that I can contribute to this fire repo

Description of Changes:

  • Added an additional step after selecting the framework
  • Injected release.yml , go-test.yml & .goreleaser.yml in root
  • Modified the necessary code to support this feature

Checklist

  • I have self-reviewed the changes being requested
  • I have updated the documentation (if applicable)
blueprint_1

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a really cool feature - however:

  • I am super hesitant in adding a third step just for work flows. It seems almost out of scope for what I had initially wanted blueprint to be.
  • This feature gave me an idea, maybe we can release a blueprint lite and blueprint full version that can include multiple steps into the process?
  • There are merge conflicts, but I am not sure if i necessarily want this feature inside of blueprint right now. Sorry.

@SudoSurya
Copy link
Contributor

instead of adding a whole new step why don't we keep it flag only if user wants workflows they just use a flag --workflows something like that.

@Ujstor
Copy link
Collaborator Author

Ujstor commented Nov 20, 2023

I'm glad that the feature interests you, and we can implement it if you decide to do so. However, I find adding it without user consent to be tricky. When users open a new project that has just been created, the large number of files can be confusing. Lite and full versions or @20pa5a1210's idea(I like it); if needed, we can find a solution.

@Melkeydev
Copy link
Owner

I was actually think about this recently and there was an idea:
we can add a --advanced flag that will give a lot more options for users to tinker/create with.
That way the lite version will continue to be the way it is now, and the advanced flag can have a ton of new features like this one.
Thoughts?

@Ujstor
Copy link
Collaborator Author

Ujstor commented Nov 22, 2023

I like the idea. I saw bsquidwrd propose this on Discord. What should I do with this PR? I can resolve the conflict and keep it up to date. However, I'm not sure that I can implement this feature alone. Some help would be nice, or I need more time to understand the logic behind it.

@Melkeydev Melkeydev changed the base branch from main to staging November 28, 2023 20:42
@Melkeydev Melkeydev changed the base branch from staging to main November 28, 2023 20:42
@Ujstor Ujstor changed the base branch from main to staging November 28, 2023 22:19
@Ujstor Ujstor changed the base branch from staging to staging-2 November 28, 2023 23:09
@Ujstor
Copy link
Collaborator Author

Ujstor commented Nov 29, 2023

There was a nasty conflict when merging my PR#108 into the staging branch. To resolve this, I created a fresh 'staging-2' branch from the current 'main'

@Ujstor Ujstor merged commit 5133906 into Melkeydev:staging-2 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants