Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input.css being public #345

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

arafays
Copy link
Contributor

@arafays arafays commented Nov 28, 2024

Problem

Closes #328 being /assets/css/input.css being publicly accessible when using tailwind with htmx

Description of Changes:

  • moved /assets/css/input.css to /styles/input.css this makes it explicit that these are styles and will not be included in assets

Checklist

@arafays
Copy link
Contributor Author

arafays commented Nov 28, 2024

I also saw that when creating htmx project without tailwind no output.css file is being created. I did not change the code as I was unsure if that was the desired behaviour and if output.css will be the correct name for it as output.css felt not the right name for it.

@arafays arafays changed the title fix: output.css being public fix: input.css being public Nov 28, 2024
@Ujstor
Copy link
Collaborator

Ujstor commented Nov 29, 2024

@mdelapenya If you have some time, can you check the issue that the linter caches?

Run cd gorilla-mux
Error: internal/database/database_test.go:27:3: undefined: testcontainers (typecheck)
		testcontainers.WithWaitStrategy(
		^
Error: Process completed with exit code 1.

@arafays
Copy link
Contributor Author

arafays commented Nov 29, 2024

I dont know but I have a hunch if we just run the tests again manually they will pass :D

@Ujstor
Copy link
Collaborator

Ujstor commented Nov 30, 2024

I dont know but I have a hunch if we just run the tests again manually they will pass :D

I reran them twice, and they failed both times.

@mdelapenya
Copy link
Contributor

I cloned this branch and tried to reproduce it locally and the CI error happens to me too: But it's not related to testcontainers, but in the previous step, the "build templates" one (see https://github.com/Melkeydev/go-blueprint/actions/runs/12074694415/job/33715796303?pr=345#step:7:22)

25l/ Preparing...- Preparing...\ Preparing...| Preparing.../ Preparing...- Preparing...25h1002l1003l2024/11/29 19:34:02 Problem creating files for project. open /home/runner/work/go-blueprint/go-blueprint/chi/cmd/web/styles/input.css: no such file or directory
Error: open /home/runner/work/go-blueprint/go-blueprint/chi/cmd/web/styles/input.css: no such file or directory
exit status 1

If you take a look at the Integration tests pipeline, they all pass.

@mdelapenya
Copy link
Contributor

mdelapenya commented Dec 2, 2024

I think that shell script should exit the pipeline at the moment it fails, not continuing the workflow

@arafays
Copy link
Contributor Author

arafays commented Dec 2, 2024

I cloned this branch and tried to reproduce it locally and the CI error happens to me too: But it's not related to testcontainers, but in the previous step, the "build templates" one (see https://github.com/Melkeydev/go-blueprint/actions/runs/12074694415/job/33715796303?pr=345#step:7:22)

25l/ Preparing...- Preparing...\ Preparing...| Preparing.../ Preparing...- Preparing...25h1002l1003l2024/11/29 19:34:02 Problem creating files for project. open /home/runner/work/go-blueprint/go-blueprint/chi/cmd/web/styles/input.css: no such file or directory
Error: open /home/runner/work/go-blueprint/go-blueprint/chi/cmd/web/styles/input.css: no such file or directory
exit status 1

If you take a look at the Integration tests pipeline, they all pass.

Well @mdelapenya thank you for pointing out where it was failing. I was able to fix the issue as the command go run main.go create -n chi -f chi -d postgres -g commit --advanced --feature tailwind was actually failing so the test were working correctly. can you tell me the process of how you run the tests locally (go noob here)? I couldn't find any documentation related to that.

@arafays arafays force-pushed the tailwind-input-ignore branch from 83088f9 to 3613395 Compare December 2, 2024 18:17
@mdelapenya
Copy link
Contributor

I usually check the pipeline/workflow file:

go test ./...

@arafays
Copy link
Contributor Author

arafays commented Dec 6, 2024

just so you know it is fixed now @Ujstor @Melkeydev

@Ujstor
Copy link
Collaborator

Ujstor commented Dec 16, 2024

I also saw that when creating htmx project without tailwind no output.css file is being created. I did not change the code as I was unsure if that was the desired behaviour and if output.css will be the correct name for it as output.css felt not the right name for it.

We implemented just a barebone example without CSS, but we could add custom, simple CSS. For now, I am accepting the current implementation, and you could open another PR if you are interested.

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit fde1fee into Melkeydev:main Dec 16, 2024
195 checks passed
@arafays arafays deleted the tailwind-input-ignore branch December 16, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /assets/css/input.css is publicly accessible
3 participants