-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: input.css being public #345
Conversation
I also saw that when creating htmx project without tailwind no output.css file is being created. I did not change the code as I was unsure if that was the desired behaviour and if output.css will be the correct name for it as output.css felt not the right name for it. |
@mdelapenya If you have some time, can you check the issue that the linter caches?
|
I dont know but I have a hunch if we just run the tests again manually they will pass :D |
I reran them twice, and they failed both times. |
I cloned this branch and tried to reproduce it locally and the CI error happens to me too: But it's not related to testcontainers, but in the previous step, the "build templates" one (see https://github.com/Melkeydev/go-blueprint/actions/runs/12074694415/job/33715796303?pr=345#step:7:22)
If you take a look at the Integration tests pipeline, they all pass. |
I think that shell script should exit the pipeline at the moment it fails, not continuing the workflow |
Well @mdelapenya thank you for pointing out where it was failing. I was able to fix the issue as the command |
83088f9
to
3613395
Compare
I usually check the pipeline/workflow file: go-blueprint/.github/workflows/ci.yml Line 51 in 389802a
|
just so you know it is fixed now @Ujstor @Melkeydev |
We implemented just a barebone example without CSS, but we could add custom, simple CSS. For now, I am accepting the current implementation, and you could open another PR if you are interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
Closes #328 being /assets/css/input.css being publicly accessible when using tailwind with htmx
Description of Changes:
Checklist