Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use PORT in React from backend .env created in frontend #355

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

sibteali786
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

This PR closes the issue/bug #350

Description of Changes:

  • Updated program.go to create and copy PORT from root .env to /frontend/env.
  • Updated app.tsx.tmpl in both react and tailwind features so that they use VITE_PORT instead of hardcoded value

Checklist

@sibteali786
Copy link
Contributor Author

@Ujstor, I'm not sure why, but the GitHub actions are failing. Do you have any suggestions on how I can test them locally to find out why this is happening?

@Ujstor
Copy link
Collaborator

Ujstor commented Dec 16, 2024

@sibteali786 Remove /dev/null after 'script' in the build ${{ matrix.driver }} template. Something changed in 'Script'...until now, workflows worked fine.

 - name: build ${{ matrix.driver }} template
   run: script -q  -c "go run main.go create -n ${{ matrix.driver }} -g commit -f fiber -d ${{ matrix.driver }}" /dev/null

Please do the same for all workflows, and on your push, the changed config will run in actions.

.github/workflows:
generate-linter-advanced.yml
generate-linter-core.yml
testcontainers.yml

@sibteali786
Copy link
Contributor Author

strange , btw @Ujstor i tried one of these script locally a while ago and it works fine without any errors

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and clean solution. LGTM!

@Ujstor Ujstor merged commit f13c8b7 into Melkeydev:main Dec 16, 2024
195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants