Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return type for postgres tests template #364

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

silaselisha
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

Postgres mustStartPostgresContainer expects to return a function of type func(ctx context.Context, opts ...testcontainers.TerminateOption) error but func(context.Context) error is returned.

Description of Changes:

  • Wrong type is returned for postgres test, hence changed the postgres template configuration to ensure that the right type is returned when generating postgres test file.

Checklist

@Ujstor Ujstor mentioned this pull request Jan 17, 2025
2 tasks
Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit b33d780 into Melkeydev:main Jan 17, 2025
32 of 195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants