Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives an error if a directory already exists. Colorized the errors when doing create if occurred #72

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Jamlie
Copy link
Contributor

@Jamlie Jamlie commented Nov 11, 2023

I made the project check the availability the given directory, if it does exist and it's not empty, it gives an error and exits.

The error messages when creating a project - if occurred - are now colored with #FF8700

@Jamlie Jamlie changed the title Gives an error if a directory already exists. Colorized the errors when creating a new project if occurred Gives an error if a directory already exists. Colorized the errors when doing create if occurred Nov 11, 2023
Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Melkeydev
Copy link
Owner

@Jamlie Please rebase - as the current PR is failing on linting checks that were fixed in a previous PR!

@Jamlie
Copy link
Contributor Author

Jamlie commented Nov 13, 2023

@Melkeydev it's done, it's ready to be merged!

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM BOIIIII

@Melkeydev Melkeydev merged commit c9d9df0 into Melkeydev:main Nov 14, 2023
9 checks passed
Ujstor added a commit to Ujstor/go-blueprint that referenced this pull request Nov 14, 2023
* Gives an error if a directory already exists. Colorized the errors when creating a new project if occurred (Melkeydev#72)

Co-authored-by: Omar <88511754+Jamlee977@users.noreply.github.com>

* fix 🐛: added hotfix to taps on homebrew (Melkeydev#87)

* fix 🐛: completion in homebrew (Melkeydev#100)

* fix 🐛: completion in homebrew

* fix 🐛: added comment about the use of the GoBlueprintVersion variable

* feat ✨: added missing completion install in goreleaser config

* fix 🐛: misstyped completion file name

* fix 🐛: permissions on completion script

* fix 🐛: missing archived complition folder needed for completion in brew

* fix 🐛: fixed ldfs flag

* docs 📚(README.md): fixed the brew installation command

* Project name input is not being sanitized (Melkeydev#103)

* fix: No project name input sanitization

* feat: Starting continuous integration

* fix: nits

---------

Co-authored-by: Omar <88511754+Jamlie@users.noreply.github.com>
Co-authored-by: Omar <88511754+Jamlee977@users.noreply.github.com>
Co-authored-by: Zine Moualhi <114167214+muandane@users.noreply.github.com>
Co-authored-by: Camilo <67205201+CamPen21@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants