Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test and some refactor #77

Closed
wants to merge 2 commits into from

Conversation

itschip
Copy link
Contributor

@itschip itschip commented Nov 12, 2023

Features:

  • Test for checking missing values between allowed types and the framework map.

Refactoring

  • Moving some logic out of the Run command to "clean it up".
  • New file project.go which inits and returns the structs needed to create the project. Would likey come in handy should there be other commands needing to use the project as well.
  • Some small changes in the ui/text after creating the project.

@itschip
Copy link
Contributor Author

itschip commented Nov 12, 2023

We could probably actually just read straight from the framework map instead of using another slice for allowed types, although it would require us to have a new function for the program pkg

@Melkeydev
Copy link
Owner

@itschip Is this still in draft? There are also conflicting files here as well

@itschip
Copy link
Contributor Author

itschip commented Nov 23, 2023

@itschip Is this still in draft? There are also conflicting files here as well

I'll clean it up and see what's changed and set it up for review within the weekend :)

@Melkeydev Melkeydev closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants