app/vfe-vdpa: fix unknown feature bit crash #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailiangz1
reviewed
Aug 26, 2022
| @@ -76,7 +87,10 @@ static void vdpa_rpc_get_info(cJSON *obj, uint64_t val, const char **info, | |||
| for (i = 0; i < size; i++) { | |||
| if (!(val & (1ULL << i))) | |||
| continue; | |||
| JSON_NUM_STR_TO_OBJ(obj, i, "%5d", info[i]); | |||
| if (info[i]) | |||
There was a problem hiding this comment.
IF i > sizeof feature_names,
it will cross mem
It is NULL when feature bit unknown and causes crash. Add check null and print unknown information in rpc message. Signed-off-by: Li Zhang <lizh@nvidia.com>
LiZhang-2020
force-pushed
the
lizh-rpc-unknown-feature-bit-crash
branch
from
f59e9f8
to
d2f7447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is NULL when feature bit unknown and causes crash.
Add check null and print unknown information in rpc message.
Signed-off-by: Li Zhang lizh@nvidia.com