Main submit #2

kailiangz1 · 2022-04-26T04:12:01Z

add virtio vdpa driver

paravmellanox · 2022-04-26T13:16:41Z

drivers/vdpa/virtio/virtio.c

+ * Copyright (c) 2022 NVIDIA Corporation & Affiliates
+ */
+
+#include <unistd.h>


@kailiangz1
Can you please take the whole code of this patch out of drivers/vdpa directory?

it should be in drivers/virtio or if its library it should be in lib/virtio.

paravmellanox · 2022-04-26T13:17:16Z

drivers/vdpa/virtio/virtio_rxtx.h

+ * Copyright (c) 2022 NVIDIA Corporation & Affiliates
+ */
+
+#ifndef _VIRTIO_RXTX_H_


VIRTNET_RX_TX_H

paravmellanox · 2022-04-26T13:17:36Z

drivers/vdpa/virtio/virtio_rxtx.h

+	uint64_t	multicast;
+	uint64_t	broadcast;
+	/* Size bins in array as RFC 2819, undersized [0], 64 [1], etc */
+	uint64_t	size_bins[8];


why is this needed?

paravmellanox · 2022-04-26T13:18:07Z

drivers/vdpa/virtio/virtio_rxtx.h

+
+struct virtnet_rx {
+	/* dummy mbuf, for wraparound when processing RX ring. */
+	struct rte_mbuf *fake_mbuf;


we are not working on any mbufs here. please remove all mbuf related code.

paravmellanox · 2022-04-26T13:18:21Z

drivers/vdpa/virtio/virtio_rxtx.h

+	uint64_t mbuf_initializer; /**< value to init mbufs. */
+	struct rte_mempool *mpool; /**< mempool for mbuf allocation */
+
+	uint16_t queue_id;   /**< DPDK queue index. */


all of this.

paravmellanox · 2022-04-26T13:26:23Z

drivers/vdpa/virtio/virtio_api.c

+
+	nr_vq = hw->max_queue_pairs * 2;
+	if (virtio_with_feature(hw, VIRTIO_NET_F_CTRL_VQ))
+		nr_vq += 1;


no. this is net specific code. it cannot be generic here.

paravmellanox · 2022-04-26T13:26:40Z

drivers/vdpa/virtio/virtio_api.c

+	PMD_INIT_LOG(DEBUG,"Guest_features is 0x%"PRIx64,hw->guest_features);
+	return vpdev;
+
+	error:


label must start at start of the line.

paravmellanox · 2022-04-26T13:27:14Z

drivers/vdpa/virtio/virtio_api.c

@@ -0,0 +1,321 @@
+/* SPDX-License-Identifier: BSD-3-Clause


name the file as just virtio.c

drop the _api.

paravmellanox · 2022-04-26T13:27:53Z

drivers/vdpa/virtio/virtio.h

+	bool use_va;
+};
+
+struct virtio_ops {


is this code copied/modified from the existing dpdk code?
if so, can we use it in its original form?

paravmellanox · 2022-04-26T13:29:16Z

drivers/vdpa/virtio/virtio.h

+
+#include <rte_ether.h>
+
+/* The feature bitmap for virtio net */


please keep net specific items in the virtio_net.h header file out of here.

paravmellanox · 2022-05-04T00:55:25Z

drivers/common/virtio/meson.build

@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2019 Mellanox Technologies, Ltd


change to latest copy right.

paravmellanox · 2022-05-04T00:56:47Z

drivers/common/virtio/virtio.c

+virtio_dev_alloc(struct rte_pci_device *pci_dev)
+{
+	struct virtio_pci_dev *vpdev;
+	struct virtio_hw *hw = NULL;


do not need to do null initialize.
you are assigning it to valid value on line 28

paravmellanox · 2022-05-04T00:57:14Z

drivers/common/virtio/virtio.c

+#include "virtio_logs.h"
+
+struct virtio_pci_dev *
+virtio_dev_alloc(struct rte_pci_device *pci_dev)


I think the api name should be virtio_pci_dev_alloc.

because it returns virtio_pci_dev pointer.

Please also change other friend functions.

paravmellanox · 2022-05-04T00:58:33Z

drivers/common/virtio/virtio.c

+	VTPCI_DEV(hw) = pci_dev;
+	ret = virtio_dev_pci_init(pci_dev, vpdev);
+	if (ret) {
+		PMD_INIT_LOG(ERR, "Failed to init virtio PCI device");


better to print the error value along with the pci device name so that we exactly know which device and error occured.

otherwise its unknown to device under debug.

Align other similar prints too.

paravmellanox · 2022-05-04T00:59:45Z

drivers/common/virtio/virtio.c

+		goto error;
+	}
+
+	/* Reset the device although not necessary at startup */


better comment is,

Reset the device, so when device is used later, reset time is saved.

paravmellanox · 2022-05-04T01:28:22Z

drivers/common/virtio/virtio.h

+	uint8_t duplex;
+	uint8_t intr_lsc;
+	uint16_t max_mtu;
+	size_t max_rx_pkt_len;


many net specific parameters to take this out or put in virtio_net_config new structure.

paravmellanox · 2022-05-04T01:28:35Z

drivers/common/virtio/virtio.h

+	 * such a contention.
+	 */
+	rte_spinlock_t state_lock;
+	struct rte_mbuf **inject_pkts;


no mbufs please.

paravmellanox · 2022-05-04T01:29:31Z

drivers/common/virtio/virtio.h

+};
+
+#define VIRTIO_OPS(hw)	((hw)->virtio_ops)
+


extra white space.

paravmellanox · 2022-05-04T01:31:32Z

drivers/common/virtio/virtio_pci.c

+
+const struct virtio_ops virtio_dev_pci_legacy_ops = {
+	.read_dev_cfg	= legacy_dev_config_read,
+	.write_dev_cfg	= legacy_dev_config_write,


remove extra white spaces

paravmellanox · 2022-05-04T01:31:47Z

drivers/common/virtio/virtio_pci.c

+io_write64_twopart(uint64_t val, uint32_t *lo, uint32_t *hi)
+{
+	rte_write32(val & ((1ULL << 32) - 1), lo);
+	rte_write32(val >> 32,		     hi);


extra white spaces.

paravmellanox · 2022-05-04T01:37:52Z

drivers/vdpa/virtio/virtio_vdpa.h

+	uint64_t guest_features;
+	pthread_mutex_t vq_config_lock;
+	int configured;
+	uint16_t nr_virtqs;   //number of vq vhost enabled


no c++ comments.

do /* */

paravmellanox · 2022-05-04T01:41:47Z

drivers/vdpa/virtio/virtio_vdpa.c

+}
+
+static int
+virtio_vdpa_vfio_intr_enable(struct virtio_vdpa_priv *priv)


No.

This code belongs in the low level virtio pci driver at virtio_pci_dev level.

paravmellanox · 2022-05-04T01:42:30Z

drivers/vdpa/virtio/virtio_vdpa.c

+}
+
+static int
+virtio_vdpa_virtq_doorbell_relay_disable(struct virtio_vdpa_priv *priv, int index)


we always want to work with direct doorbells.

so please remove this code.

no, mlx5_vdpa still have this code and it can be used because some time vhost msg come and
doorbell map still not run.

paravmellanox · 2022-05-04T01:42:48Z

drivers/vdpa/virtio/virtio_vdpa.c

+	struct virtio_dev_vring_info vring_info;
+	uint64_t gpa;
+
+	if(enable==0) {


white spaces

paravmellanox · 2022-05-04T01:44:04Z

drivers/vdpa/virtio/virtio_vdpa.c

+
+	DRV_LOG(INFO, "vDPA device %d  set vring %d state %d.", vid, vring, state);
+	priv->vrings[vring]->enable = !!state;
+	if((priv->configured)&&(state)&&(vring== (rte_vhost_get_vring_num(vid)-1))) {


something looks hacky here, or I don;t fully understand this.

will move to driver_ok after Yajun's patch, this is temporary solution.

paravmellanox · 2022-05-10T22:03:17Z

drivers/common/virtio/virtio_ring.h

+
+struct vring {
+	unsigned int num;
+	struct vring_desc  *desc;


please dont add any extra white space to right align.

C does left align the code. remove it.

paravmellanox · 2022-05-10T22:03:50Z

drivers/common/virtio/virtio_ring.h

+};
+
+struct vring {
+	unsigned int num;


have structure nauturally aligned without holds unless it is absolute necessary.

so move this to the end of the struct.

paravmellanox · 2022-05-10T22:04:07Z

drivers/common/virtio/virtio_ring.h

+};
+
+struct vring_packed {
+	unsigned int num;


move this variable to end of the structure.

paravmellanox · 2022-05-10T22:07:12Z

drivers/common/virtio/virtio_pci.c

+				break;
+			}
+
+			if (flags & PCI_MSIX_ENABLE)


better rewrite it as,

return (flags & PCI_MSIX_ENABLE) ? VIRTIO_MSIX_ENABLED : VIRTIO_MSIX_DISABLED;

you can see such usage in VIRTIO_PCI_CONFIG.

paravmellanox · 2022-05-10T22:08:20Z

drivers/common/virtio/virtio_pci.c

+ * Copyright (c) 2022 NVIDIA Corporation & Affiliates
+ */
+
+#include <stdint.h>


if you are moving the code from X file to Y file.
Do not copy, you have to delete the code from some file that from where you are moving.

paravmellanox · 2022-05-10T22:10:45Z

drivers/common/virtio/virtio_pci.c

+	return 0;
+}
+
+const struct virtio_ops virtio_dev_pci_modern_ops = {


this should be static.

same for the legacy ops too.

paravmellanox · 2022-05-10T22:12:38Z

drivers/common/virtio/virtio.c

+
+	return irq_info.count;
+}
+#define VFIO_FD_INVALID -1


empty line needed before this define

paravmellanox · 2022-05-10T22:13:20Z

drivers/common/virtio/virtio.c

+	}
+	return 0;
+}
+int


blank line needed

paravmellanox · 2022-05-10T22:13:42Z

drivers/common/virtio/virtio.c

+	rte_free(irq_set);
+	if (ret) {
+		PMD_INIT_LOG(ERR, "Dev %s enabling MSI-X: %s", VP_DEV_NAME(vpdev), strerror(errno));
+		return ret;


no need for this return inside.

always do return ret on line 260.

paravmellanox · 2022-05-10T22:15:25Z

drivers/common/virtio/virtio.c

+	struct virtio_hw *hw = &vpdev->hw;
+
+	VIRTIO_OPS(hw)->set_status(hw, VIRTIO_CONFIG_STATUS_RESET);
+	/* Flush status write and wait device ready max 3 seconds. */


3 seconds is too less for us during dpu reboots.

it should be close to 120 secs.

paravmellanox · 2022-05-14T00:43:03Z

drivers/vdpa/virtio/virtio_vdpa.h

@@ -0,0 +1,63 @@
+/* SPDX-License-Identifier: BSD-3-Clause


since there is single file who is using this, there is no need of a separate header file.

Move them to virtio_vdpa.c

paravmellanox · 2022-05-14T00:44:15Z

drivers/vdpa/virtio/virtio_vdpa.h

+	uint64_t used;
+	uint16_t size;
+	uint16_t last_avail_idx;
+	uint16_t last_used_idx; /*other is for future use, not use now*/


it should be,

/* It is for future use */

Actually remove it from this patch, if we are not using it.
lets add when you actually use it.
it keeps review and code small.

paravmellanox · 2022-05-14T00:44:56Z

drivers/vdpa/virtio/virtio_vdpa.h

+	uint16_t last_used_idx; /*other is for future use, not use now*/
+	bool enable;
+	uint8_t notifier_state;
+	uint16_t index;


move index variable up.
keep things naturally aligned.
so move bool at the end of the struct along with notifier_state.

paravmellanox · 2022-05-14T00:45:17Z

drivers/vdpa/virtio/virtio_vdpa.h

+};
+
+#define VIRTIO_VDPA_DRIVER_NAME vdpa_virtio
+//TO_DO: need to add VHOST_USER_PROTOCOL_F_CONFIG later


no cpp style comment.
/* Comment */

paravmellanox · 2022-05-14T00:46:47Z

drivers/vdpa/virtio/virtio_vdpa.h

+*/
+struct virtio_vdpa_priv {
+	TAILQ_ENTRY(virtio_vdpa_priv) next;
+	struct rte_pci_device *pdev;


evaluate why do we need to know about pdev.
It should not be here.
we are working on top of virtio_pci_dev vpdev or rte_vdpa_device.

we should not directly access rte_pci_device at this layer.
Please remove or schedule a call for all the things that I do not understand.

we need to access intr_handle at virtio-vdpa.c to configure device level interrupt .
intr_handle is stored in rte_pci_device

paravmellanox · 2022-05-14T01:31:12Z

drivers/vdpa/virtio/virtio_vdpa.c

+	if (ret)
+		return ret;
+
+	ret =virtio_pci_dev_interrupts_enable(priv->vpdev, vq.callfd, index+1);


this should be done only one, or its name should be pci_dev_interrupt_enable

interrupt is enabled per queue, so, i just need to change to pci_dev_interrupt_enable?

paravmellanox · 2022-05-14T01:32:12Z

drivers/vdpa/virtio/virtio_vdpa.c

+	priv->vrings[index]->size = vq.size;
+	vring_info.size = vq.size;
+
+	DRV_LOG(DEBUG, "Virtq %d nr_entrys:%d",index, vq.size);


white space before index

paravmellanox · 2022-05-14T01:32:34Z

drivers/vdpa/virtio/virtio_vdpa.c

+
+	priv->vrings[index]->notifier_state = VIRTIO_VDPA_NOTIFIER_STATE_DISABLED;
+
+	ret = virtio_pci_dev_interrupts_disable(priv->vpdev, index+1);


white space

index + 1

paravmellanox · 2022-05-14T01:32:53Z

drivers/vdpa/virtio/virtio_vdpa.c

+
+	virtio_pci_dev_queue_del(priv->vpdev, index);
+
+	priv->vrings[index]->notifier_state = VIRTIO_VDPA_NOTIFIER_STATE_DISABLED;


this should be after interrupt disablement call is successful.

paravmellanox · 2022-05-14T01:35:10Z

drivers/vdpa/virtio/virtio_vdpa.c

+	uint64_t buf;
+	int nbytes;
+
+	if(!(priv->configured))


braces before priv is not needed.

it should be,

if (!priv->configured || !virtq->enable)
return;

cut down line 142 and 143.

paravmellanox · 2022-05-17T02:10:50Z

drivers/common/virtio/virtio_pci.c

+ */
+
+#ifdef RTE_EXEC_ENV_LINUX
+ #include <dirent.h>


no white space needed at beginning.

paravmellanox · 2022-05-18T22:20:59Z

drivers/vdpa/virtio/virtio_vdpa.c

+virtio_vdpa_find_priv_resource_by_vdev(const struct rte_vdpa_device *vdev)
+{
+	struct virtio_vdpa_priv *priv;
+	int found = 0;


use bool

bool found = false;

paravmellanox · 2022-05-18T22:22:04Z

drivers/vdpa/virtio/virtio_vdpa.c

+		DRV_LOG(ERR, "Invalid vDPA device: %s", vdev->device->name);
+		return -ENODEV;
+	}
+	/* TO_DO:for net, should use max_virtqueue_pairs? may be is same */


remove this todo, it belong to virtio layer.

virtio layer will do max_qps vs other count.

paravmellanox · 2022-05-18T22:24:32Z

drivers/vdpa/virtio/virtio_vdpa.c

+
+static int
+virtio_vdpa_virtq_doorbell_relay_enable(struct virtio_vdpa_priv *priv,
+															int vq_idx)


fix alignment.
cannot figure out from this patch if its right or not.

paravmellanox · 2022-05-18T22:25:12Z

drivers/vdpa/virtio/virtio_vdpa.c

+	}
+
+	return 0;
+error:


empty line needed before the label.

paravmellanox · 2022-05-18T22:40:35Z

drivers/vdpa/virtio/virtio_vdpa.c

+					priv->vdev->device->name, ret);
+	}
+
+	virtio_pci_dev_reset(priv->vpdev);


This needs to be done before doing dma unmap.
otherwise memory is unmapped but device VQ are still working on these vqs.

So reset the device so that VQ traffic stops.

paravmellanox · 2022-05-18T22:40:52Z

drivers/vdpa/virtio/virtio_vdpa.c

+
+	virtio_pci_dev_reset(priv->vpdev);
+
+	/* Disable all queue*/


add white space after "queue"

and say "queues".

paravmellanox · 2022-05-18T22:55:35Z

drivers/vdpa/virtio/virtio_vdpa.c

+	}
+
+	virtio_pci_dev_queues_free(priv->vpdev, nr_vq);
+


remove this empty line.

paravmellanox · 2022-05-18T23:01:29Z

drivers/vdpa/virtio/virtio_vdpa.c

+	struct virtio_vdpa_priv *priv = NULL;
+	int found = 0, ret;
+
+	pthread_mutex_lock(&priv_list_lock);


use the function you have start the beginning of the file.

paravmellanox · 2022-05-18T23:01:59Z

drivers/vdpa/virtio/virtio_vdpa.c

+		rte_free(priv);
+	}
+
+	if (!found)


return found ? 0 : -ENODEV;

The interface of virtio device driver is virtio_api.h All the api function have parameter struct virtio_pci_dev* and it is allocated in function virtio_dev_alloc Signed-off-by: Kailiang Zhou <kailiangz@nvidia.com>

This vdpa driver works on top of virtio device layer use virtio_api.h Only support 1 queue pair for virtio net device. Signed-off-by: Kailiang Zhou <kailiangz@nvidia.com>

In rte_vhost_driver_unregister which is called from vdpa-rpc thread, vsocket should be removed from reconn_list again after remove vsocket from conn_list. Because vhost_user_read_cb which is called in vhost-events thread can add vsocket to reconn_list again. When qemu close domain socket server, vhost_user_read_cb will be called to clean up vhost device. vsocket->path is NULL #0 0x00007f07665834d1 in __strnlen_sse2 () from /lib64/libc.so.6 Mellanox#1 0x00007f076aee79da in vhost_user_add_connection (fd=160, vsocket=0x7f070406d160) at ../lib/vhost/socket.c:226 Mellanox#2 0x00007f076aee7d63 in vhost_user_client_reconnect (arg=<optimized out>) at ../lib/vhost/socket.c:481 Mellanox#3 0x00007f07668cbdd5 in start_thread () from /lib64/libpthread.so.0 Mellanox#4 0x00007f07665f4ead in clone () from /lib64/libc.so.6 RM: 3585558 Signed-off-by: Yajun Wu <yajunw@nvidia.com>

In rte_vhost_driver_unregister which is called from vdpa-rpc thread, vsocket should be removed from reconn_list again after remove vsocket from conn_list. Because vhost_user_read_cb which is called in vhost-events thread can add vsocket to reconn_list again. When qemu close domain socket server, vhost_user_read_cb will be called to clean up vhost device. vsocket->path is NULL #0 0x00007f07665834d1 in __strnlen_sse2 () from /lib64/libc.so.6 #1 0x00007f076aee79da in vhost_user_add_connection (fd=160, vsocket=0x7f070406d160) at ../lib/vhost/socket.c:226 #2 0x00007f076aee7d63 in vhost_user_client_reconnect (arg=<optimized out>) at ../lib/vhost/socket.c:481 #3 0x00007f07668cbdd5 in start_thread () from /lib64/libpthread.so.0 #4 0x00007f07665f4ead in clone () from /lib64/libc.so.6 RM: 3585558 Signed-off-by: Yajun Wu <yajunw@nvidia.com>

[ upstream commit 1c80a40 ] The net/vhost pmd currently provides a -1 vid when disabling interrupt after a virtio port got disconnected. This can be caught when running with ASan. First, start dpdk-l3fwd-power in interrupt mode with a net/vhost port. $ ./build-clang/examples/dpdk-l3fwd-power -l0,1 --in-memory \ -a 0000:00:00.0 \ --vdev net_vhost0,iface=plop.sock,client=1\ -- \ -p 0x1 \ --interrupt-only \ --config '(0,0,1)' \ --parse-ptype 0 Then start testpmd with virtio-user. $ ./build-clang/app/dpdk-testpmd -l0,2 --single-file-segment --in-memory \ -a 0000:00:00.0 \ --vdev net_virtio_user0,path=plop.sock,server=1 \ -- \ -i Finally stop testpmd. ASan then splats in dpdk-l3fwd-power: ================================================================= ==3641005==ERROR: AddressSanitizer: global-buffer-overflow on address 0x000005ed0778 at pc 0x000001270f81 bp 0x7fddbd2eee20 sp 0x7fddbd2eee18 READ of size 8 at 0x000005ed0778 thread T2 #0 0x1270f80 in get_device .../lib/vhost/vhost.h:801:27 Mellanox#1 0x1270f80 in rte_vhost_get_vhost_vring .../lib/vhost/vhost.c:951:8 Mellanox#2 0x3ac95cb in eth_rxq_intr_disable .../drivers/net/vhost/rte_eth_vhost.c:647:8 Mellanox#3 0x170e0bf in rte_eth_dev_rx_intr_disable .../lib/ethdev/rte_ethdev.c:5443:25 Mellanox#4 0xf72ba7 in turn_on_off_intr .../examples/l3fwd-power/main.c:881:4 Mellanox#5 0xf71045 in main_intr_loop .../examples/l3fwd-power/main.c:1061:6 Mellanox#6 0x17f9292 in eal_thread_loop .../lib/eal/common/eal_common_thread.c:210:9 Mellanox#7 0x18373f5 in eal_worker_thread_loop .../lib/eal/linux/eal.c:915:2 Mellanox#8 0x7fddc16ae12c in start_thread (/lib64/libc.so.6+0x8b12c) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) Mellanox#9 0x7fddc172fbbf in __GI___clone3 (/lib64/libc.so.6+0x10cbbf) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) 0x000005ed0778 is located 8 bytes to the left of global variable 'vhost_devices' defined in '.../lib/vhost/vhost.c:24' (0x5ed0780) of size 8192 0x000005ed0778 is located 20 bytes to the right of global variable 'vhost_config_log_level' defined in '.../lib/vhost/vhost.c:2174' (0x5ed0760) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow .../lib/vhost/vhost.h:801:27 in get_device Shadow bytes around the buggy address: 0x000080bd2090: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000080bd20a0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000080bd20b0: f9 f9 f9 f9 00 f9 f9 f9 00 f9 f9 f9 00 f9 f9 f9 0x000080bd20c0: 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 04 f9 f9 f9 0x000080bd20d0: 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 =>0x000080bd20e0: 00 f9 f9 f9 f9 f9 f9 f9 04 f9 f9 f9 04 f9 f9[f9] 0x000080bd20f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000080bd2100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000080bd2110: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000080bd2120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000080bd2130: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Thread T2 created by T0 here: #0 0xe98996 in __interceptor_pthread_create (.examples/dpdk-l3fwd-power+0xe98996) (BuildId: d0b984a3b0287b9e0f301b73426fa921aeecca3a) Mellanox#1 0x1836767 in eal_worker_thread_create .../lib/eal/linux/eal.c:952:6 Mellanox#2 0x1834b83 in rte_eal_init .../lib/eal/linux/eal.c:1257:9 Mellanox#3 0xf68902 in main .../examples/l3fwd-power/main.c:2496:8 Mellanox#4 0x7fddc164a50f in __libc_start_call_main (/lib64/libc.so.6+0x2750f) (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) ==3641005==ABORTING More generally, any application passing an incorrect vid would trigger such an OOB access. Fixes: 4796ad6 ("examples/vhost: import userspace vhost application") Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

kailiangz1 force-pushed the main_submit branch from a56bccc to f437217 Compare April 26, 2022 06:56

paravmellanox reviewed Apr 26, 2022

View reviewed changes

kailiangz1 force-pushed the main_submit branch 5 times, most recently from 2bbb951 to 88266d2 Compare April 29, 2022 12:28

paravmellanox reviewed May 4, 2022

View reviewed changes

kailiangz1 force-pushed the main_submit branch 7 times, most recently from 6be860d to b23554f Compare May 10, 2022 06:49

paravmellanox reviewed May 10, 2022

View reviewed changes

kailiangz1 force-pushed the main_submit branch 2 times, most recently from e28ce93 to f1d099b Compare May 11, 2022 04:02

paravmellanox reviewed May 14, 2022

View reviewed changes

kailiangz1 force-pushed the main_submit branch 4 times, most recently from 686ba38 to 5082a4e Compare May 18, 2022 02:11

paravmellanox reviewed May 18, 2022

View reviewed changes

kailiangz1 force-pushed the main_submit branch from 5082a4e to 20942b3 Compare May 19, 2022 03:41

kailiangz1 added 2 commits May 19, 2022 06:48

virtio/dev: Add common virtio device driver

22d9d50

The interface of virtio device driver is virtio_api.h All the api function have parameter struct virtio_pci_dev* and it is allocated in function virtio_dev_alloc Signed-off-by: Kailiang Zhou <kailiangz@nvidia.com>

vdpa/virtio: Add new virtio vdpa driver

5b0c524

This vdpa driver works on top of virtio device layer use virtio_api.h Only support 1 queue pair for virtio net device. Signed-off-by: Kailiang Zhou <kailiangz@nvidia.com>

kailiangz1 force-pushed the main_submit branch from 20942b3 to 5b0c524 Compare May 19, 2022 03:49

paravmellanox merged commit 33a6a93 into Mellanox:main May 19, 2022


		#include <rte_ether.h>

		/* The feature bitmap for virtio net */

		@@ -0,0 +1,9 @@
		# SPDX-License-Identifier: BSD-3-Clause
		# Copyright 2019 Mellanox Technologies, Ltd


		priv->vrings[index]->notifier_state = VIRTIO_VDPA_NOTIFIER_STATE_DISABLED;

		ret = virtio_pci_dev_interrupts_disable(priv->vpdev, index+1);


		virtio_pci_dev_queue_del(priv->vpdev, index);

		priv->vrings[index]->notifier_state = VIRTIO_VDPA_NOTIFIER_STATE_DISABLED;

Main submit #2

Main submit #2

Conversation

kailiangz1 commented Apr 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment