vdpa/virtio: fix remove vf crash #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When virtio device back-end isn't available, virtio_vdpa_dev_close will return because of admin q command failure. Missing calling virtio_vdpa_virtq_doorbell_relay_disable causes following crash: PANIC in eal_intr_thread_main(): Error adding fd 177 epoll_ctl, Bad file descriptor Remove all the error return in virtio_vdpa_dev_close, so all the resource can be cleaned. RM: 3417752 Signed-off-by: Yajun Wu <yajunw@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When virtio device back-end isn't available, virtio_vdpa_dev_close will return because of admin q command failure. Missing calling virtio_vdpa_virtq_doorbell_relay_disable causes following crash:
PANIC in eal_intr_thread_main():
Error adding fd 177 epoll_ctl, Bad file descriptor
Remove all the error return in virtio_vdpa_dev_close, so all the resource can be cleaned.
RM: 3417752