vdpa/virtio: fix blk crash at eal_intr_thread_main #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutdown multiple blk device, dpdk crash: VHOST_CONFIG: (/tmp/sock-blk-10) vhost peer closed PANIC in eal_intr_thread_main(): Error adding fd 589 epoll_ctl, Bad file descriptor 5: [/lib64/libc.so.6(clone+0x6d) [0x7ffff5a8cead]] 4: [/lib64/libpthread.so.0(+0x7dd5) [0x7ffff5d63dd5]] 3: [/root/dpdk-vhost-vfe/build/app/dpdk-vfe-vdpa() [0x137a711]] 2: [/root/dpdk-vhost-vfe/build/app/dpdk-vfe-vdpa(__rte_panic+0xba) [0x5ab12d]] 1: [/root/dpdk-vhost-vfe/build/app/dpdk-vfe-vdpa(rte_dump_stack+0x1a) [0x1377faa]] kickfd/callfd is closed in vhost_user_get_vring_base, virtio_vdpa_virtq_doorbell_relay_disable should be called in or before virtio_vdpa_dev_close. Fixes: 92535c4 ("vdpa/virtio: Fix wrong set vring base(used index)") Fixes: 4f778ec ("vdpa/virtio: fix mem hotplug wrong queue disable") RM: 3669299 Signed-off-by: Yajun Wu <yajunw@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutdown multiple blk device, dpdk crash:
kickfd/callfd is closed in vhost_user_get_vring_base, virtio_vdpa_virtq_doorbell_relay_disable should be called in or before virtio_vdpa_dev_close.
Fixes: 92535c4 ("vdpa/virtio: Fix wrong set vring base(used index)")
Fixes: 4f778ec ("vdpa/virtio: fix mem hotplug wrong queue disable")
RM: 3669299