vdpa/virtio: disable queues in dev close #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajwu
force-pushed
the
pr_hotplug_mem_again
branch
5 times, most recently
from
912a33c
to
c20a489
Compare
vhost_user_get_vring_base calls virtio_vdpa_dev_close, then closes kickfd and callfd. So doolbell notifier and interrupt should be released in virtio_vdpa_dev_close. !! Still disable qeueues in virtio_vdpa_dev_close. !! Keep same as before 4f778ec ("vdpa/virtio: fix mem hotplug wrong queue disable"). For mem hotplug case: virtio_vdpa_dev_close called in vhost_user_set_mem_table. Let's save the queue enable configration in a new variable and together with queue enable to enable queues again in virtio_vdpa_dev_config. Fixes: 4f778ec ("vdpa/virtio: fix mem hotplug wrong queue disable") Signed-off-by: Yajun Wu <yajunw@nvidia.com>
yajwu
force-pushed
the
pr_hotplug_mem_again
branch
from
c20a489
to
6d8c956
Compare
yajwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.