vdpa/virtio: fix dev close double free #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailiangz1
reviewed
Feb 20, 2024
drivers/vdpa/virtio/virtio_vdpa.c
Outdated
| } | ||
| } | ||
|
|
||
| rte_free(tmp_hw_idx); |
There was a problem hiding this comment.
how about remove these 2 line?
if virtio_pci_dev_state_hw_idx_get fail, tmp_hw_idx freed twice, then cause crash. RM: 3738339 Signed-off-by: Yajun Wu <yajunw@nvidia.com>
yajwu
force-pushed
the
fix_close_double_free
branch
from
59f0e2d
to
ecd7189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if virtio_pci_dev_state_hw_idx_get fail, tmp_hw_idx freed twice, then cause crash.
RM: 3738339