app/vfe-vdpa: Remove GUEST_ANNOUNCE feature when set #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3n60x
reviewed
Apr 1, 2024
drivers/vdpa/virtio/virtio_vdpa.c
Outdated
| @@ -1112,6 +1112,10 @@ virtio_vdpa_features_set(int vid) | |||
| /* TO_DO: check why --- */ | |||
| features |= (1ULL << VIRTIO_F_IOMMU_PLATFORM); | |||
| features |= (1ULL << VIRTIO_F_RING_RESET); | |||
| if (priv->dev_ops->set_vdpa_feature) { | |||
| priv->dev_ops->set_vdpa_feature(&features); | |||
| } | |||
Ch3n60x
reviewed
Apr 1, 2024
| struct virtio_vdpa_device_callback virtio_vdpa_net_callback = { | ||
| .vhost_feature_get = virtio_vdpa_net_vhost_feature_get, | ||
| .dirty_desc_get = virtio_vdpa_net_dirty_desc_get, | ||
| .reg_dev_intr = NULL, | ||
| .unreg_dev_intr = NULL, | ||
| .vdpa_queue_num_unit_get = virtio_vdpa_net_queue_num_unit_get, | ||
| .add_vdpa_feature = virtio_vdpa_net_add_vdap_feature, | ||
| .set_vdpa_feature = virtio_vdpa_net_set_vdap_feature, |
There was a problem hiding this comment.
vdap->vdpa? also for 'add_vdpa_feature'
There was a problem hiding this comment.
add_vdpa_feature is used when get feature, will add VIRTIO_NET_F_GUEST_ANNOUNCE
and need to unmask it when set feature because we didn't create ctrl vq
In virtio spec, GUEST_ANNOUNCE rely on ctrl vq, but current VFE didn't have ctrl vq, so, unmask it when set. RM: 3827154 Signed-off-by: Kailiang <kailiangz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In virtio spec, GUEST_ANNOUNCE rely on ctrl vq, but current VFE didn't have ctrl vq, so, unmask it when set.
RM: 3827154