-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app/vfe-vdpa: Remove GUEST_ANNOUNCE feature when set #67
Conversation
drivers/vdpa/virtio/virtio_vdpa.c
Outdated
@@ -1112,6 +1112,10 @@ virtio_vdpa_features_set(int vid) | |||
/* TO_DO: check why --- */ | |||
features |= (1ULL << VIRTIO_F_IOMMU_PLATFORM); | |||
features |= (1ULL << VIRTIO_F_RING_RESET); | |||
if (priv->dev_ops->set_vdpa_feature) { | |||
priv->dev_ops->set_vdpa_feature(&features); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{} not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
struct virtio_vdpa_device_callback virtio_vdpa_net_callback = { | ||
.vhost_feature_get = virtio_vdpa_net_vhost_feature_get, | ||
.dirty_desc_get = virtio_vdpa_net_dirty_desc_get, | ||
.reg_dev_intr = NULL, | ||
.unreg_dev_intr = NULL, | ||
.vdpa_queue_num_unit_get = virtio_vdpa_net_queue_num_unit_get, | ||
.add_vdpa_feature = virtio_vdpa_net_add_vdap_feature, | ||
.set_vdpa_feature = virtio_vdpa_net_set_vdap_feature, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vdap->vdpa? also for 'add_vdpa_feature'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add_vdpa_feature is used when get feature, will add VIRTIO_NET_F_GUEST_ANNOUNCE
and need to unmask it when set feature because we didn't create ctrl vq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
In virtio spec, GUEST_ANNOUNCE rely on ctrl vq, but current VFE didn't have ctrl vq, so, unmask it when set. RM: 3827154 Signed-off-by: Kailiang <kailiangz@nvidia.com>
In virtio spec, GUEST_ANNOUNCE rely on ctrl vq, but current VFE didn't have ctrl vq, so, unmask it when set.
RM: 3827154