vdpa/virtio: limit max VFIO group number in container #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPDK EAL layer has limited the maximum number of VFIO group in one VFIO container to 64. So error will be returned if we try to add more than 64 VFs in the container. Although VFIO container/group bind API will check this, it will result in 120 times retry in the driver. This commit limit the max VFIO group number before group bind to avoid the retry time. RM: 3845142 Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
kailiangz1
reviewed
Apr 1, 2024
| @@ -2106,6 +2106,12 @@ virtio_vdpa_dev_probe(struct rte_pci_driver *pci_drv __rte_unused, | |||
| pthread_mutex_init(&iommu_domain->domain_lock, NULL); | |||
| } | |||
|
|
|||
| if (iommu_domain->container_ref_cnt == RTE_MAX_VFIO_GROUPS) { | |||
There was a problem hiding this comment.
if vm_uuid is NULL, we will never reach this limit?
There was a problem hiding this comment.
yes. for VF that has null vm_uuid, it will have its own iommu domain and no other VFs can find the domain and use. So the container_ref_cnt will be 0 or 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPDK EAL layer has limited the maximum number of VFIO group in one VFIO container to 64. So error will be returned if we try to add more than 64 VFs in the container. Although VFIO container/group bind API will check this, it will result in 120 times retry in the driver. This commit limit the max VFIO group number before group bind to avoid the retry time.
RM: 3845142