vdpa/virtio: fix dirty logging stop #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajwu
force-pushed
the
pr_fix_logging_stop
branch
from
375820b
to
ac4eda0
Compare
When live migration fail on destination, source qemu will send stop logging(by `set_features`) to dpdk, virtio vdpa driver is missing sending this stop logging to controller. Start another round LM, the repeated start logging will cause controller return error and dpdk stuck in retry admin queue command. Add log_started flag to save current logging state and send log stop to controller. RM: 3851825 Signed-off-by: Yajun Wu <yajunw@nvidia.com>
yajwu
force-pushed
the
pr_fix_logging_stop
branch
from
ac4eda0
to
3b00c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When live migration fail on destination, source qemu will send stop logging(by
set_features) to dpdk, virtio vdpa driver is missing sending this stop logging to controller. Start another round LM, the repeated start logging will cause controller return error and dpdk stuck in retry admin queue command.Add log_started flag to save current logging state and send log stop to controller.
RM: 3851825