vdpa/virtio: re-implement iommu domain #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailiangz1
reviewed
Apr 24, 2024
drivers/vdpa/virtio/virtio_vdpa.c
Outdated
| @@ -2220,6 +2224,7 @@ virtio_vdpa_dev_probe(struct rte_pci_driver *pci_drv __rte_unused, | |||
| } | |||
|
|
|||
| priv->iommu_domain = iommu_domain; | |||
| pthread_mutex_init(&priv->domain_lock, NULL); | |||
There was a problem hiding this comment.
if 2 vf use same iommu domain, but they will use different lock to protect same iommu domain?
There was a problem hiding this comment.
yes, current code is wrong
Ch3n60x
changed the title
This commit changes iommu domain list to an array and adds a new lock array to protect the iommu domain. This re-implementation is for improving the thread-safety of iommu domain. Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes iommu domain list to an array and adds a new lock
array to protect the iommu domain. This re-implementation is for
improving the thread-safety of iommu domain.