bug fix - move fd store time and mtu set #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3n60x
reviewed
Apr 29, 2024
| snprintf(args + offset, RTE_DEV_NAME_MAX_LEN, ",%s=%s", VIRTIO_ARG_VDPA_STAGE, VIRTIO_ARG_VDPA_VALUE_STAGE); | ||
| offset += snprintf(args + offset, RTE_DEV_NAME_MAX_LEN, ",%s=%s", VIRTIO_ARG_VDPA_STAGE, VIRTIO_ARG_VDPA_VALUE_STAGE); | ||
|
|
||
| offset += snprintf(args + offset, MAX_PATH_LEN, ",%s=%s", VIRTIO_ARG_VDPA_SOCK_PATH, ifname); |
There was a problem hiding this comment.
this 'offset +=' seems not needed as offset is not used later
There was a problem hiding this comment.
just in case we add another line , needed add + again.
Ch3n60x
reviewed
Apr 29, 2024
drivers/vdpa/virtio/virtio_vdpa.c
Outdated
| @@ -2034,6 +2018,14 @@ virtio_pci_devargs_parse(struct rte_devargs *devargs, int *vdpa, rte_uuid_t vm_u | |||
| DRV_LOG(ERR, "Failed to parse %s", VIRTIO_ARG_VDPA_STAGE); | |||
| } | |||
|
|
|||
| if (rte_kvargs_count(kvlist, VIRTIO_ARG_VDPA_SOCK_PATH) == 1) { | |||
| /* stage mode selected, debug only | |||
| */ | |||
There was a problem hiding this comment.
above comment is wrong due to copy-paste
After customer probe the device, we should noitfy HA, and vfs will recover after probe instead of only after device config. Signed-off-by: Kailiang <kailiangz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.