app/vfe-vdpa: add wait time after socket start #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailiangz1
reviewed
Apr 30, 2024
app/vfe-vdpa/vdpa_ha.c
Outdated
| @@ -267,9 +272,21 @@ virtio_ha_client_dev_restore_vf(int total_vf) | |||
| } | |||
| pthread_mutex_unlock(&vf_restore_lock); | |||
| total_vf--; | |||
| usleep(MIN_WAIT_TIME); | |||
There was a problem hiding this comment.
if vhost fd = -1, we should not wait
There was a problem hiding this comment.
MIN_WAIT_TIME seems not necessary
When multiple VFs belong to single VM, QEMU handles the vhost-user message resend of devices one by one and the vhost fds close happen really quickly. This leads to downtime increase for VFs that restore late, as they need to wait for VFs driver ok on QEMU side. This commit fixes this issue by adding wait time per-VF. Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple VFs belong to single VM, QEMU handles the vhost-user message resend of devices one by one and the vhost fds close happen really quickly. This leads to downtime increase for VFs that restore late, as they need to wait for VFs driver ok on QEMU side. This commit fixes this issue by adding wait time per-VF.