-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid guid pool exhaustion from guid leaks by syncing it with SM #92
Conversation
Pull Request Test Coverage Report for Build 3287401876Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
10e0803
to
7547370
Compare
7547370
to
e1065dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits otherwise LGTM
If the node running pods that use ib network is restarted, those pods' GUID are deleted from UFM but are persisted in ib-kubernetes. They become unusable and might exhaust the GUID pool if it's configured to be small enough. The solution is to sync guid pool with UFM because some GUIDs might have become free to use. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
e1065dd
to
795a29a
Compare
If the node running pods that use ib network is restarted, those pods'
GUID are deleted from UFM but are persisted in ib-kubernetes.
They become unusable and might exhaust the GUID pool if it's configured to be small enough.
The solution is to sync guid pool with UFM because some GUIDs might have become free to use.
Signed-off-by: amaslennikov amaslennikov@nvidia.com